#508 closed task (fixed)
Remove string members in render styles
| Reported by: | waltweltonlair | Owned by: | waltweltonlair |
|---|---|---|---|
| Priority: | medium | Milestone: | 2.1 |
| Component: | General | Version: | 2.0.0 |
| Severity: | minor | Keywords: | |
| Cc: | External ID: | 1064832 |
Description
The SE_RenderStyle derived structs contain a number of string members (e.g. angleControl, vertexControl), and the rendering code uses string comparison calls to branch based on their values. This all happens inside the rendering loop. A more efficient implementation is to use enumerated types in place of these string members. In the common case (no expressions) the strings are then evaluated only once when the style is evaluated.
Change History (4)
comment:1 by , 17 years ago
| Status: | new → assigned |
|---|
comment:2 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Implemented with submission https://trac.osgeo.org/mapguide/changeset/3102.
comment:3 by , 17 years ago
| External ID: | → 1064832 |
|---|
comment:4 by , 17 years ago
Merged fix into branch stream with submission https://trac.osgeo.org/mapguide/changeset/3130.
Note:
See TracTickets
for help on using tickets.
Another benefit to doing this is that schema-specific behavior (such as handling of deprecated and default values) is less spread out.