MgRaster serialization error

[jng]

Attempting to serialize a MgRaster with palette information will crash the MapGuide Server.

The problem is that the m_palette member is a MgByte, which does not inherit from MgSerializable, thus the resulting call to MgStreamWriter::WriteObject() performs an invalid cast on the MgByte to MgSerializable

The solution is to either:

• Implement a MgSerializable wrapper for MgByte objects
• Use a non-WriteObject method for serializing the MgByte object (not sure if this can be done)

[jng]

Fix serialization/deserialization

[trevorwekel]

Hi Jackie, the patch is fine. You might want to check your tab settings. The alignment looks off in the patch.

You may also want to add a dynamic cast to MgSerializable from MgObject in MgStreamWriter::WriteObject, check for NULL, and throw an exception.

The blind cast from MgObject to MgSerializable is bad. Ideally, WriteObject should be taking an MgSerializable. Unfortunately, that change would impact MgCommand logic and may be too invasive. Maybe a 2.5 item.

I did a search in the code base for WriteObject taking non-serializable arguments. I didn't see any other instances of this. Near as I can tell, this has been in here for years.

[jng]

Testing tab formatting

[jng]

Fixed r6547