Dropping layer into group doesn't work

[andrewd]

Create a map with some layer groups (not base layers), then try dragging and dropping a layer from the site explorer into a group. the layer ends up just being added to the root. You then have to drag it from there up to the group.

[jng]

Cannot reproduce. If the folder in question is not highlighted when you drop it, it's not going to go into that folder and so defaults to the root.

[andrewd]

You've just described the bug (or at least, perceived bug) right there...Generally, you don't have to preselect a folder when dragging and dropping in other software.

As a user, I certainly assume that things will just go where I drop them, whether or not I preselect a folder. The fact that they don't may be by design, but it's very much non-standard, and I'd consider changing it if you'd like to make Maestro more user-friendly.

Change it to an enhancement request if you'd rather not treat it as a bug...but I'd keep it on the list.

[jng]

If your mouse pointer is over the folder in the action of dragging, it gets highlighted. So I cannot see what the problem is.

[andrewd]

Ok - got more detail for you...

Expand the group folder (put some layers into it first). Drag something into it without putting your mouse over the folder, so it gives you the short horizontal line indicating it's going to put it in that folder (this happens when hovering between 2 layers in the group)...drop the layer, and it will be placed at the root, not the folder. This is more of a problem with large expanded groups, when you can't see the group folder icon. Basically, the short lines (the ones that appear in folders) never seem to work.

Also, if you happen to drop a layer on top of an existing layer in a group, maybe you could make that be treated as though it was dropped in the group - right now, if you do that, it gets put in the root.

[jng]

Ok, this make sense. If the drop target is inside a folder it should infer this as the drop target, whether or not the folder in question is actually highlighted

[jng]

Fixed in trunk (r6657) and 4.0.x (r6659)

Note that due to some quirks with the tree view we're using (it's not the stock WinForms treeview), you still need the drop target layer node to be highlighted or have the black horizontal line displaying for it to properly locate the parent group to add your dropped layer into.