Opened 10 years ago

Closed 9 years ago

#956 closed defect (fixed)

gis.m fixes for 6.4 (backport patch from 6.5)

Reported by: neteler Owned by: grass-dev@…
Priority: normal Milestone: 6.4.0
Component: Tcl/Tk Version: svn-releasebranch64
Keywords: gis.m Cc:
CPU: Unspecified Platform: Unspecified

Description

Attached the changes for 6.4-gis.m as backport patch from 6.5 for review.

Markus

Attachments (2)

gis_m.diff (34.9 KB) - added by neteler 10 years ago.
gis.m patches polished
gis.m_65_merge.diff (31.1 KB) - added by marisn 10 years ago.
Stripped out 6.5 specific new modules and not loved GRASS session termination. Everything else should be safe.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by neteler

Attachment: gis_m.diff added

gis.m patches polished

comment:1 Changed 10 years ago by hamish

Thanks for preparing this, it was a bit of an unknown how the two branches had diverged.

I am very much against bulk backports. It destroys any hope of stabilizing the codebase. Lets do backports bug by bug please, dictated by need and with justification.

especially from 6.5 guis, which are full of new experimental features which do not belong in the stable branch.

rather, I would like us to use this patch as a menu of what things could be backported and pick out the important bugfixes.

Backport selected great features to 6.4.1 if you like, but please please please bug-fixes-only for the 6.4.0 branch. I am getting very frustrated that we are never going to release this thing, and every time we add a new feature we reset the stability clock.

gmmenu.tcl:

v.in.lines

-> new module not in 6.4 AFAIK

{[G_msg "Exit &GRASS"]} {command {[G_msg "&Quit GIS Ma ... # Provides remote exit call.

-> I wouldn't mind backporting ctrl-q to exit the wxgui, but am against the full Quit all the grass terminal from the gui menu going in to 6.4.0. it is too raw. actually IMHO I wonder if it should be removed from both wxGUI in trunk, and 6.5 in tcl+wx as a mis-feature, but I'm happy for it to stay for testing in the dev branches. The wx one in grass7 fails badly for me and leaves the shell in a broken state fwiw, and in 6.5 it doesn't work at all.

other new modules

-> some are there, but check all actually present in 6.4

...

set m [GSelect paint/labels title [G_msg "Label file"]]

-> ISTR this one was a bug with a report ?

thanks, Hamish

Changed 10 years ago by marisn

Attachment: gis.m_65_merge.diff added

Stripped out 6.5 specific new modules and not loved GRASS session termination. Everything else should be safe.

comment:2 Changed 9 years ago by marisn

Resolution: fixed
Status: newclosed

gis.m in 6.4.1 is synced to 6.5 (except "Exit GRASS" feature). Should fix also some unreported issues. r43690 r43691 r43692

Note: See TracTickets for help on using tickets.