Opened 11 years ago

Closed 8 years ago

#597 closed defect (fixed)

Digitize tool won't work

Reported by: vince Owned by: martinl
Priority: normal Milestone: 6.4.2
Component: wxGUI Version: 6.4.0 RCs
Keywords: digitize Cc: grass-dev@…
CPU: x86-64 Platform: MacOSX

Description

When I launch the digitize tool under wxpython GUI, all seems to be fine (buttons appears, I can select a layer with the combo box, etc.), but when I click for the first time (or any time after), I have a "no layer selected for editing" error message. In other words: I can't digitize nothing!

Change History (17)

comment:1 Changed 11 years ago by martinl

Cc: grass-dev@… added
Component: defaultwxGUI
Owner: changed from grass-dev@… to martinl
Status: newassigned

OK, I did you select any vector layer for editing or created new one?

comment:2 Changed 11 years ago by vince

Both. Neither does work.

In the README of the RC4 version, it is written (I have discovered that afterwards) that digitize won't work in 64-bit mode. I can't figure if it won't work or it won't compile. If the former, then my ticket is maybe purposeless; if the latter, then it is wrong, since I have a v.digitize module installed for both x64 and i386 archs. Yet, I get the GUI addition all right, so it's bizarre.

comment:3 Changed 11 years ago by kyngchaos

vdigit in the wxGUI is python-based. It won't compile or run for 64bit OSX. But, even when the rest of GRASS is 64bit, vdigit (and wx nviz) will compile and run for 32bit OSX.

v.digit (vector/v.digit) will compile 64bit, since it's not python-based. I don't see anything in the README that says it won't run on 64bit OSX (unless you mean the macosx/readme.rtf), but it's possible and very likely - there were problems in the vector dglib for OSX 64bit that have been fixed in trunk, but I don't know if they were backported, since the fix was indirectly a result of another bugfix.

comment:4 Changed 11 years ago by vince

Okay, so if I am not mistaken, I made a confusion between vdigit and v.digit. Apologies.

Yes, I meant the macosx/readme.rtf, sorry for being a bit unspecific.

So, the best is maybe that I fetch the SVN version and retry. I am a bit reluctant to propose a svn-based macport, but if it has special fixes for OS X that are not available in the main release, it can make sense.

comment:5 Changed 11 years ago by kyngchaos

... I just dug around for the details (need to dust off the cobwebs in my memory) - looks like the bug was fixed in February, and I verified it. trunk r36003 and devbr6 r36049. BUT, it appears this didn't make it into release 6.4.

It would be nice to get this into 6.4, but it might be too late. Maybe 6.4.1? If that is not going to happen, then I'd say that GRASS 6.4 is still not ready for 64bit OSX.

comment:6 Changed 11 years ago by kyngchaos

... for reference: it's bug #431.

comment:7 Changed 11 years ago by vince

Ok, fine thanks a lot and sorry for the inconvenience. I'm going to alter the port to fetch the svn version instead, at least until a stable version with correct 64-bit OS X support is released. Anyhow, a full 64-bit build will not be possible until Wxwidgets itself is 64-bit safe, that is the Cocoa port is finished. At that time, only Qgis offer full 64-bit mode under OS X, since Qt 4.5 moved to Cocoa.

Thanks again

comment:8 in reply to:  5 Changed 11 years ago by hamish

Replying to kyngchaos:

... I just dug around for the details (need to dust off the cobwebs in my memory) - looks like the bug was fixed in February, and I verified it. trunk r36003 and devbr6 r36049. BUT, it appears this didn't make it into release 6.4.

It would be nice to get this into 6.4, but it might be too late. Maybe 6.4.1? If that is not going to happen, then I'd say that GRASS 6.4 is still not ready for 64bit OSX.

it has been in 6.5svn for 3 months (apparently) without problems, so for my vote I'd say go ahead and risk the backport for 6.4.0.

Hamish

comment:9 Changed 11 years ago by kyngchaos

...It appears it has been backported already to 6.4 release (r36838), it was just too late for the rc4 tarball. So this v.digit 64bit sidetrack is taken care of.

comment:10 Changed 11 years ago by vince

It still does not work in RC5…

comment:11 Changed 11 years ago by kyngchaos

Well, I found that if I select "Digitize" from the toolbar popup on the display window, I get the same "no layer selected" error. But if I right-click a vector layer in the layer manager and "Start editing", digitizing works.

comment:12 Changed 10 years ago by cmbarton

Still broken in 6.4.

Michael

comment:13 Changed 10 years ago by cmbarton

Works for me in 6.4 and 6.5 on the Mac. Can anyone confirm that this is still broken after William changed the way this is compiled on a Mac?

Michael

comment:14 Changed 9 years ago by martinl

Milestone: 6.4.06.4.2

comment:15 Changed 8 years ago by martinl

please try recent 6.4.2 from SVN...

comment:16 Changed 8 years ago by cmbarton

The wxDigitizer now seems to work fine in GRASS 6.4.2 (assuming it is installed and activated.). No crash when making point, line, area.

Michael

comment:17 Changed 8 years ago by martinl

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.