Opened 11 years ago

Closed 11 years ago

#554 closed defect (fixed)

wxGUI location wizard: Search in description with 0 hits

Reported by: hamish Owned by: martinl
Priority: major Milestone: 6.4.0
Component: wxGUI Version: 6.4.0 RCs
Keywords: location wizard Cc: grass-dev@…
CPU: x86-32 Platform: MSWindows XP

Description

Hi,

in the latest 6.4.0svn wingrass build from osgeo4w--

  • startup with wxgui.
  • Define new location via location wizard.
  • by epsg code (list comes up now, great to see that fixed!)
  • Search in description: _ something with no hits, eg 4326 or typo

At this point the list of codes is empty and the following error message appears on the DOS console window:

Traceback (most recent call last):
 File "C:\OSGeo4W\apps\grass\grass-6.4.0svn\etc\wxpython\gui_modules\location_wizard.py", line 1365, in OnSearch
    self.epsgcode = self.epsglist.Search(index=1, str=value)[0]
TypeError: 'NoneType' object is unsubscriptable

so I guess two things are needed:

  • only try to grab epsg code to fill in "EPSG code: " box if >=1 result was found, and
  • automatically reload EPSG codes before each new search (if 0 hits then the 'search in desc' box is unusable until you press the Reload EPSG Codes button.

thanks, Hamish

Change History (11)

comment:1 Changed 11 years ago by hamish

also in the location wizard, it would be really nice for lat/lon locations if the "Set default region extent and resolution" would accept the "DDD:MM:SS.SSSh" format. (swig G_scan_northing()?)

currently if you try that it gives an error: (e.g. for 48deg South lat) "Invalid value: invalid literal for float(): 48S"

Hamish

comment:2 in reply to:  description ; Changed 11 years ago by neteler

Replying to hamish:

Hi,

in the latest 6.4.0svn wingrass build from osgeo4w--

(that's from 29-Mar-2009)

Can you please try http://grass.osgeo.org/grass64/binary/mswindows/native/WinGRASS-6.4.0RC4-1-Setup.exe

which is more recent?

comment:3 in reply to:  2 Changed 11 years ago by hamish

Replying to neteler:

Can you please try http://grass.osgeo.org/grass64/binary/mswindows/native/WinGRASS-6.4.0RC4-1-Setup.exe

which is more recent?

ok ......... nope, not fixed. same thing happens.

Hamish

comment:4 in reply to:  description ; Changed 11 years ago by martinl

Cc: grass-dev@… added
Owner: changed from grass-dev@… to martinl
Status: newassigned

Replying to hamish:

  • Search in description: _ something with no hits, eg 4326 or typo

you search in the description, not in the codes - so you get empty list. Use "Reload EPGS codes" to reload the list.

At this point the list of codes is empty and the following error message appears on the DOS console window:

Traceback (most recent call last):
 File "C:\OSGeo4W\apps\grass\grass-6.4.0svn\etc\wxpython\gui_modules\location_wizard.py", line 1365, in OnSearch
    self.epsgcode = self.epsglist.Search(index=1, str=value)[0]
TypeError: 'NoneType' object is unsubscriptable

Fixed in r36775.

so I guess two things are needed:

  • only try to grab epsg code to fill in "EPSG code: " box if >=1 result was found, and
  • automatically reload EPSG codes before each new search (if 0 hits then the 'search in desc' box is unusable until you press the Reload EPSG Codes button.

Done in r36776.

M.

comment:5 in reply to:  2 ; Changed 11 years ago by martinl

Hi,

Replying to neteler:

http://grass.osgeo.org/grass64/binary/mswindows/native/WinGRASS-6.4.0RC4-1-Setup.exe

could we release also weekly updated native installer? - to enable users to test recently fixed bugs?

Martin

comment:6 in reply to:  4 ; Changed 11 years ago by neteler

Replying to martinl:

Replying to hamish:

  • Search in description: _ something with no hits, eg 4326 or typo

you search in the description, not in the codes - so you get empty list. Use "Reload EPGS codes" to reload the list.

Could the search code be changed to also search in the EPSG codes? I get regularly trapped that it isn't possible (often I want to search for a code to see if I recalled the number correctly)

Markus

comment:7 in reply to:  5 Changed 11 years ago by neteler

Replying to martinl:

Hi,

Replying to neteler:

http://grass.osgeo.org/grass64/binary/mswindows/native/WinGRASS-6.4.0RC4-1-Setup.exe

could we release also weekly updated native installer? - to enable users to test recently fixed bugs?

That would be great. FBK Trento promised to me to set up something like this but I don't know if it will happen. Maybe we should install a buildbot instance at OSGeo?

Markus

comment:8 in reply to:  6 Changed 11 years ago by martinl

Replying to neteler:

Could the search code be changed to also search in the EPSG codes? I get regularly trapped that it isn't possible (often I want to search for a code to see if I recalled the number correctly)

Done in r36795.

Martin

comment:9 in reply to:  5 Changed 11 years ago by cnielsen

could we release also weekly updated native installer? - to enable users to test recently fixed bugs?

I'm having some hardware issues right now (my laptop screen died). I'll release another wingrass installer when I get this resolved. Sorry for the inconvenience. However, the files and steps required (recently updated) to make an installer are in the source code if someone else wants to give it a try in the meantime. -Colin

comment:10 Changed 11 years ago by cnielsen

All seems to work fine in the new winGrass I just finished. I'll post it shortly.

-Colin

comment:11 Changed 11 years ago by hamish

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.