Opened 3 years ago

Closed 3 years ago

#3899 closed defect (fixed)

g.gui.gmodeler: loading of modeller file broken with TypeError

Reported by: neteler Owned by: grass-dev@…
Priority: normal Milestone: 7.8.0
Component: wxGUI Version: git-releasebranch78
Keywords: python3 Cc:
CPU: Unspecified Platform: Unspecified

Description

Loading of the modeller file crashes with:

GRASS 7.8.dev (Dachbegruenung):~ > g.gui.gmodeler /scratch/Meike/GM/model_Bonn.gxm
Traceback (most recent call last):
  File "/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/scripts/g.gui.gmodeler", line 63, in <module>
    main()
  File "/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/scripts/g.gui.gmodeler", line 57, in main
    frame.LoadModelFile(options['file'])
  File "/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/frame.py", line 1050, in LoadModelFile
    self.model.LoadModel(filename)
  File "/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/model.py", line 332, in LoadModel
    x=action['pos'][0],
TypeError: 'NoneType' object is not subscriptable


g.version -rge
version=7.8.dev
date=2019
revision=82b7ad4db
build_date=2019-08-20
build_platform=x86_64-pc-linux-gnu
build_off_t_size=8
libgis_revision=00000
libgis_date="?"
proj4=4.9.3
gdal=2.3.2
geos=3.6.1
sqlite=3.26.0

Probably a missing update to Python3?

Change History (4)

comment:1 by pesekon2, 3 years ago

It works for me and I believe that it should be fixed by this commit: https://github.com/OSGeo/grass/commit/82793da8c6772e87c2c3de4e8f2256612d1e6c76

Could you upload your model, please?

in reply to:  1 ; comment:2 by neteler, 3 years ago

Replying to pesekon2:

It works for me and I believe that it should be fixed by this commit: https://github.com/OSGeo/grass/commit/82793da8c6772e87c2c3de4e8f2256612d1e6c76

Wonderful, it works now! Thanks a lot.

Only this msg clutter remained:

/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:952: wxPyDeprecationWarning: Call to deprecated item. Use InsertItem instead.
  index = self.InsertStringItem(i, str(i))
/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:953: wxPyDeprecationWarning: Call to deprecated item. Use SetItem instead.
  self.SetStringItem(index, 0, name)
/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:954: wxPyDeprecationWarning: Call to deprecated item. Use SetItem instead.
  self.SetStringItem(index, 1, inloop)
/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:955: wxPyDeprecationWarning: Call to deprecated item. Use SetItem instead.
  self.SetStringItem(index, 2, param)
/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:956: wxPyDeprecationWarning: Call to deprecated item. Use SetItem instead.
  self.SetStringItem(index, 3, desc)

in reply to:  2 comment:3 by pesekon2, 3 years ago

Replying to neteler:

Only this msg clutter remained:

/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:952: wxPyDeprecationWarning: Call to deprecated item. Use InsertItem instead.
  index = self.InsertStringItem(i, str(i))
/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:953: wxPyDeprecationWarning: Call to deprecated item. Use SetItem instead.
  self.SetStringItem(index, 0, name)
/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:954: wxPyDeprecationWarning: Call to deprecated item. Use SetItem instead.
  self.SetStringItem(index, 1, inloop)
/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:955: wxPyDeprecationWarning: Call to deprecated item. Use SetItem instead.
  self.SetStringItem(index, 2, param)
/home/mundialis/software/grass78_git/dist.x86_64-pc-linux-gnu/gui/wxpython/gmodeler/dialogs.py:956: wxPyDeprecationWarning: Call to deprecated item. Use SetItem instead.
  self.SetStringItem(index, 3, desc)

Yes, I know. Yesterday, I have created a pull request to get rid of these messages (they appeared on more places after switching to wxPython4): https://github.com/OSGeo/grass/pull/120

comment:4 by neteler, 3 years ago

Resolution: fixed
Status: newclosed
Version: unspecifiedgit-releasebranch78

Great, merged and all solved. Thanks!

Note: See TracTickets for help on using tickets.