Opened 3 years ago

Closed 2 years ago

#3301 closed enhancement (fixed)

r.seasons: add option to use an input map with per-cell thresholds

Reported by: veroandreo Owned by: grass-dev@…
Priority: normal Milestone: 7.4.0
Component: Addons Version: 7.2.0
Keywords: r.seasons Cc:
CPU: Unspecified Platform: Unspecified

Description

The possibility to use an input map with per-cell thresholds in r.seasons would be very useful (not necesarily to replace the current threshold parameter, but as a different parameter). This would allow to pass a map of thresholds representing the median of the input time series in each pixel, for example.

Change History (6)

comment:1 Changed 3 years ago by martinl

Milestone: 7.2.17.2.2

comment:2 in reply to:  description ; Changed 3 years ago by mmetz

Replying to veroandreo:

The possibility to use an input map with per-cell thresholds in r.seasons would be very useful (not necesarily to replace the current threshold parameter, but as a different parameter). This would allow to pass a map of thresholds representing the median of the input time series in each pixel, for example.

A new option tmap to use a raster map with per-cell threshold values has been added in r71070. The threshold option has been renamed to tval. Either tval or tmap must be provided.

comment:3 in reply to:  2 ; Changed 3 years ago by neteler

Replying to mmetz:

The threshold option has been renamed to tval. Either tval or tmap must be provided.

Shy suggestion: to follow the G7 parameter name scheme, something with _value would be better. Like in r.sun or other modules:

            aspect   Name of the input aspect map (terrain aspect or azimuth of the solar panel) [decimal degrees]
      aspect_value   A single value of the orientation (aspect), 270 is south
                     default: 270
             slope   Name of the input slope raster map (terrain slope or solar panel inclination) [decimal degrees]
       slope_value   A single value of inclination (slope)
                     default: 0.0

AFAIK "tval" whould still work due to the parser magic with underscores.

comment:4 in reply to:  3 Changed 3 years ago by mmetz

Replying to neteler:

Replying to mmetz:

The threshold option has been renamed to tval. Either tval or tmap must be provided.

Shy suggestion: to follow the G7 parameter name scheme, something with _value would be better.

OK, tval has been changed to threshold_value and tmap has been changed to threshold_map in r71078.

comment:5 Changed 2 years ago by martinl

Milestone: 7.2.27.4.0

All enhancement tickets should be assigned to 7.4 milestone.

comment:6 Changed 2 years ago by veroandreo

Resolution: fixed
Status: newclosed

Thanks much! Closing

Note: See TracTickets for help on using tickets.