Opened 14 years ago

Last modified 3 years ago

#32 new enhancement

r.what: shouldn't use static buffers for the inputs

Reported by: 1gray Owned by: grass-dev@…
Priority: minor Milestone: 7.6.2
Component: Raster Version: svn-trunk
Keywords: r.what Cc:
CPU: Unspecified Platform: Unspecified

Description

It seems that I'm a lucky one to face all these ``static buffer'' issues.

$ r.what \
      input=2006-08-{0{1,2,3,4,5,6,7,8,9},{1,2}{0,1,2,3,4,5,6,7,8,9},3{0,1}}.[...].{{1,2,3,4,5,6,7,8,9},1{0,1,2,3,4,5,6,7,8,9},20} \
      east_north=[...]
r.what: can only do up to 150 cell files, sorry
$ 

Surely I can raise NFILES in raster/r.what/main.c, but wouldn't it be better to replace all the mess in r.what with a pure dynamic buffer-based solution? (Hopefully I could make a patch.)

I've tested the command above with GRASS 6.2.3-debian-1, but I can see the relevant code in a recent SVN trunk as well.

Change History (15)

comment:1 in reply to:  description ; Changed 14 years ago by 1gray

On the other hand, (much of) the r.what functionality could easily be achieved by using v.what.rast together with v.db.select.

Shouldn't therefore r.rast be replaced by a (supposedly simpler) Shell script?

comment:2 in reply to:  1 Changed 14 years ago by glynn

Replying to 1gray:

Shouldn't therefore r.rast be replaced by a (supposedly simpler) Shell script?

No. For a start, v.what.rast only accepts a single raster map. Also, r.what shouldn't depend upon the vector and database functionality (most raster modules should still work if e.g. you can't GDAL to work).

comment:3 Changed 12 years ago by hamish

Component: defaultRaster
CPU: Unspecified
Keywords: r.what added
Platform: Unspecified

comment:4 Changed 6 years ago by neteler

Milestone: 6.4.07.0.3
Type: defectenhancement

The limit of currently #define NFILES 400 continues to exist.

comment:5 Changed 6 years ago by neteler

See also #2564

comment:6 Changed 6 years ago by neteler

Milestone: 7.0.3

Ticket retargeted after milestone closed

comment:7 Changed 6 years ago by neteler

Milestone: 7.0.4

Ticket retargeted after 7.0.3 milestone closed

comment:8 Changed 6 years ago by martinl

Milestone: 7.0.47.0.5

comment:9 Changed 5 years ago by martinl

Milestone: 7.0.57.3.0

comment:10 Changed 5 years ago by martinl

Milestone: 7.3.07.4.0

Milestone renamed

comment:11 Changed 4 years ago by neteler

Milestone: 7.4.07.4.1

Ticket retargeted after milestone closed

comment:12 Changed 3 years ago by neteler

Milestone: 7.4.17.4.2

comment:13 Changed 3 years ago by martinl

Milestone: 7.4.27.6.0

All enhancement tickets should be assigned to 7.6 milestone.

comment:14 Changed 3 years ago by martinl

Milestone: 7.6.07.6.1

Ticket retargeted after milestone closed

comment:15 Changed 3 years ago by martinl

Milestone: 7.6.17.6.2

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.