Opened 17 years ago
Last modified 5 years ago
#32 new enhancement
r.what: shouldn't use static buffers for the inputs
| Reported by: | 1gray | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 7.6.2 |
| Component: | Raster | Version: | svn-trunk |
| Keywords: | r.what | Cc: | |
| CPU: | Unspecified | Platform: | Unspecified |
Description
It seems that I'm a lucky one to face all these ``static buffer'' issues.
$ r.what \
input=2006-08-{0{1,2,3,4,5,6,7,8,9},{1,2}{0,1,2,3,4,5,6,7,8,9},3{0,1}}.[...].{{1,2,3,4,5,6,7,8,9},1{0,1,2,3,4,5,6,7,8,9},20} \
east_north=[...]
r.what: can only do up to 150 cell files, sorry
$
Surely I can raise NFILES in raster/r.what/main.c, but
wouldn't it be better to replace all the mess in r.what with a
pure dynamic buffer-based solution? (Hopefully I could make a patch.)
I've tested the command above with GRASS 6.2.3-debian-1, but I can see the relevant code in a recent SVN trunk as well.
Change History (15)
follow-up: 2 comment:1 by , 17 years ago
comment:2 by , 17 years ago
Replying to 1gray:
Shouldn't therefore
r.rastbe replaced by a (supposedly simpler) Shell script?
No. For a start, v.what.rast only accepts a single raster map. Also, r.what shouldn't depend upon the vector and database functionality (most raster modules should still work if e.g. you can't GDAL to work).
comment:3 by , 15 years ago
| Component: | default → Raster |
|---|---|
| CPU: | → Unspecified |
| Keywords: | r.what added |
| Platform: | → Unspecified |
comment:4 by , 9 years ago
| Milestone: | 6.4.0 → 7.0.3 |
|---|---|
| Type: | defect → enhancement |
The limit of currently #define NFILES 400 continues to exist.
comment:8 by , 8 years ago
| Milestone: | 7.0.4 → 7.0.5 |
|---|
comment:9 by , 8 years ago
| Milestone: | 7.0.5 → 7.3.0 |
|---|
comment:12 by , 6 years ago
| Milestone: | 7.4.1 → 7.4.2 |
|---|
comment:13 by , 6 years ago
| Milestone: | 7.4.2 → 7.6.0 |
|---|
All enhancement tickets should be assigned to 7.6 milestone.

On the other hand, (much of) the
r.whatfunctionality could easily be achieved by usingv.what.rasttogether withv.db.select.Shouldn't therefore
r.rastbe replaced by a (supposedly simpler) Shell script?