Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2560 closed defect (fixed)

Various typo fixes

Reported by: Bas Couwenberg Owned by: grass-dev@…
Priority: normal Milestone: 7.0.0
Component: Docs Version: svn-releasebranch70
Keywords: patch Cc: sebastic@…
CPU: Unspecified Platform: All

Description

The lintian QA tool reported various typos during the Debian package build process for 7.0.0RC1.

The attached patches fix the various issues, and are included in the Debian package being prepared by the Debian GIS team.

Attachments (10)

additionally-typo.patch (1.6 KB) - added by Bas Couwenberg 5 years ago.
allows-to-typo.patch (15.5 KB) - added by Bas Couwenberg 5 years ago.
available-typo.patch (649 bytes) - added by Bas Couwenberg 5 years ago.
default-typo.patch (684 bytes) - added by Bas Couwenberg 5 years ago.
extension-typo.patch (2.2 KB) - added by Bas Couwenberg 5 years ago.
information-typo.patch (9.6 KB) - added by Bas Couwenberg 5 years ago.
parameter-typo.patch (6.2 KB) - added by Bas Couwenberg 5 years ago.
preferred-typo.patch (614 bytes) - added by Bas Couwenberg 5 years ago.
specifying-typo.patch (1.5 KB) - added by Bas Couwenberg 5 years ago.
transferred-typo.patch (4.8 KB) - added by Bas Couwenberg 5 years ago.

Download all attachments as: .zip

Change History (13)

Changed 5 years ago by Bas Couwenberg

Attachment: additionally-typo.patch added

Changed 5 years ago by Bas Couwenberg

Attachment: allows-to-typo.patch added

Changed 5 years ago by Bas Couwenberg

Attachment: available-typo.patch added

Changed 5 years ago by Bas Couwenberg

Attachment: default-typo.patch added

Changed 5 years ago by Bas Couwenberg

Attachment: extension-typo.patch added

Changed 5 years ago by Bas Couwenberg

Attachment: information-typo.patch added

Changed 5 years ago by Bas Couwenberg

Attachment: parameter-typo.patch added

Changed 5 years ago by Bas Couwenberg

Attachment: preferred-typo.patch added

Changed 5 years ago by Bas Couwenberg

Attachment: specifying-typo.patch added

Changed 5 years ago by Bas Couwenberg

Attachment: transferred-typo.patch added

comment:1 Changed 5 years ago by neteler

Resolution: fixed
Status: newclosed

Thanks for the patches. All applied in r64320 (trunk) and r64321 (relbranch70). Closing.

comment:2 Changed 5 years ago by wenzeslaus

It does not seem to me that there is any way to run these checks on the source code. Is there some other easy way to run it?

comment:3 in reply to:  2 Changed 5 years ago by Bas Couwenberg

Replying to wenzeslaus:

It does not seem to me that there is any way to run these checks on the source code. Is there some other easy way to run it?

The easier way to use lintian is to include it in the Debian package build process. To support lintian-overrides you need to add dh_lintian calls to the rules file. The following change was added to the official Debian package maintained by the Debian GIS team for example:

http://anonscm.debian.org/cgit/pkg-grass/grass.git/commit/?id=55bbe45b9881321ce3fb4dda3728d2a8abe7c3a1

I suggest you include dh_lintian in the upstream GRASS packaging on Launchpad. This patch should work on the current grass70_release_debian bzr branch (revision 45):

=== modified file 'rules'
--- rules       2014-08-11 09:11:22 +0000
+++ rules       2015-02-01 17:29:31 +0000
@@ -232,6 +232,7 @@
        dh_installdocs -i
        dh_install -i
        dh_link -i
+       dh_lintian -i
        dh_strip -i
        dh_compress -i
        dh_fixperms -i
@@ -254,6 +255,7 @@
        dh_installmenu -a
        dh_installman -p$(PKG_NAME) debian/$(BASE_NAME).1 -a
        dh_link -a
+       dh_lintian -a
        dh_python2
        dh_python2 /usr/lib/$(BASE_NAME)/gui/
        dh_strip -a

After the package build process is completed you run lintian on the .changes file produced by the build. You can do this by default by including a pbuilder hook for lintian as documented in the Debian GIS Policy:

http://pkg-grass.alioth.debian.org/policy/packaging.html#git-pbuilder-hooks

Note: See TracTickets for help on using tickets.