Opened 8 years ago

Closed 7 years ago

#2223 closed defect (fixed)

v.buffer flags -s and -c not working(?)

Reported by: jbrauner Owned by: grass-dev@…
Priority: normal Milestone: 7.0.2
Component: Vector Version: svn-trunk
Keywords: v.buffer Cc:
CPU: Unspecified Platform: All

Description

Hi devs,

browsed the dev and user lists and the trac for a while but came up with zero results. Sorry, if this was already reported before.

In winGRASS (latest build) and Linux (ppa:grass/grass-devel) the -s (make outside corners straigth) and -c (don't make caps at the end of lines) flags don't seem to influence the result (still caps and round corners everywhere). I've used the roadsmajor of the NC dataset with a buffer distance of 1000.

In winGRASS6.4.3 and GRASS 6.4.2 (ubuntugis) it still works with the older version of the NC dataset.

I've only raised one issue here for the time being - both flags seem to be somehow related (to me ;)). If you prefer having two separate tickets, please give me a hint.

I took a quick look at the sources - but I've no clue. Sorry.

If you need more info, please let me know. I just stumbled upon this issue, it's no blocking issue here for me.

Cheers,

Johannes

Change History (9)

comment:1 by neteler, 8 years ago

To my knowledge v.buffer only works properly when compiled with GEOS support.

comment:2 by neteler, 8 years ago

Priority: minorcritical

See also #1464 (v.buffer needs to be compiled with GEOS support).

See also #1343

in reply to:  1 ; comment:3 by jbrauner, 8 years ago

Replying to neteler:

To my knowledge v.buffer only works properly when compiled with GEOS support.

Isn't at least winGRASS (sorry my Linux box is broken at the moment) compiled with GEOS support? As far as I can conclude from the build information (see below) and the extended list of available operators for v.select it seems very likely to me. Sorry if this is an unqualified comment :)

Cheers,

Johannes

g.version -bre
GRASS 7.1.svn (2014)
 ./configure [... snip ...] --with-geos=/c/osgeo4w/usr/src/grass_trunk/mswindows/osgeo4w/geos-config [... snip ...]
libgis Revision: 59317 
libgis Date: 2014-03-24 20:38:32 +0100 (po, 24 III 2014) 
PROJ.4: 4.8.0
GDAL/OGR: 1.10.1
GEOS: 3.4.2
SQLite: 3.7.17

in reply to:  3 comment:4 by martinl, 8 years ago

Replying to jbrauner:

Isn't at least winGRASS (sorry my Linux box is broken at the moment) compiled with GEOS support? As far as I can conclude from the build information (see below) and the extended

yes, it's compiled with GEOS support.

comment:5 by neteler, 8 years ago

Resolution: wontfix
Status: newclosed

The flags have been inactivated (i.e. present for backward compatibility) but have no effect when using GEOS.

The module v.buffer has been rebased on GEOS in r59970 which you now need to compile it in order to solve other buffering bugs.

(Note: Any potential use of special GEOS features may be implemented

in GRASS 7)

in reply to:  5 comment:6 by neteler, 7 years ago

Priority: criticalnormal
Resolution: wontfix
Status: closedreopened

Replying to neteler:

The flags have been inactivated (i.e. present for backward compatibility) but have no effect when using GEOS.

I wonder why -c wasn't removed.

comment:7 by martinl, 7 years ago

Milestone: 7.0.07.0.1

I implemented support for -s and -c flag in r65710 (for GEOS mode which is default). After some testing it can be backported to relbr70.

Last edited 7 years ago by martinl (previous) (diff)

comment:8 by neteler, 7 years ago

Milestone: 7.0.17.0.2

Ticket retargeted after 7.0.1 milestone closed

comment:9 by martinl, 7 years ago

Resolution: fixed
Status: reopenedclosed

Already done in r65957. Closing.

Note: See TracTickets for help on using tickets.