Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#2148 closed enhancement (fixed)

wxGUI modeler: allow to name elements in the model schema

Reported by: mlennert Owned by: grass-dev@…
Priority: normal Milestone: 7.0.5
Component: wxGUI Version: svn-trunk
Keywords: modeller comments Cc:
CPU: Unspecified Platform: Unspecified

Description

It would be nice if by changing the name of an object in the Objects tab, this name would replace the name of the command in the model display. Currently setting this name just is ignored and is lost after saving and reopening the model.

In addition, the possibility to add comments would be nice, possibly in the form of a comment object that would be ignored in the model.

Moritz

Attachments (2)

modeler-label-comment.png (15.6 KB) - added by martinl 5 years ago.
Set command label and comment
modeler-comment.png (10.2 KB) - added by martinl 5 years ago.
command with and without a comment, separate comment

Download all attachments as: .zip

Change History (10)

comment:1 in reply to:  description ; Changed 6 years ago by martinl

Replying to mlennert:

It would be nice if by changing the name of an object in the Objects tab, this name would replace the name of the command in the model display. Currently setting this name just is ignored and is lost after saving and reopening the model.

it was hopefully fixed in r58518, you can set action name/label in 'Items' tab or from contextual menu ('Set label').

In addition, the possibility to add comments would be nice, possibly in the form of a comment object that would be ignored in the model.

This has been implemented in r58521. You can set comments from contextual menu, it's saved to model file. I am not sure how to display them, probably as tooltips or directly in the object shape below label. Any opinions?

comment:2 in reply to:  1 ; Changed 5 years ago by mlennert

Replying to martinl:

Replying to mlennert:

It would be nice if by changing the name of an object in the Objects tab, this name would replace the name of the command in the model display. Currently setting this name just is ignored and is lost after saving and reopening the model.

it was hopefully fixed in r58518, you can set action name/label in 'Items' tab or from contextual menu ('Set label').

Works now, thanks !

In addition, the possibility to add comments would be nice, possibly in the form of a comment object that would be ignored in the model.

This has been implemented in r58521. You can set comments from contextual menu, it's saved to model file. I am not sure how to display them, probably as tooltips or directly in the object shape below label. Any opinions?

I think the ideal would be to be able to add comments independent of objects. Sometimes comments can be about a process that includes several objects. And for such comments it would be nice to have a specific form not yet used by other types of obects (triangle, hexagon, ...).

And to push things even further: it would be nice if these comments then also show up in the Python code...

Moritz

Changed 5 years ago by martinl

Attachment: modeler-label-comment.png added

Set command label and comment

comment:3 in reply to:  2 ; Changed 5 years ago by martinl

Replying to mlennert:

It would be nice if by changing the name of an object in the Objects tab, this name would replace the name of the command in the model display. Currently setting this name just is ignored and is lost after saving and reopening the model.

it was hopefully fixed in r58518, you can set action name/label in 'Items' tab or from contextual menu ('Set label').

Works now, thanks !

I have also modified dialog for adding new commands to the model which now enables setting label and comment, see attachment:modeler-label-comment.png

In addition, the possibility to add comments would be nice, possibly in the form of a comment object that would be ignored in the model.

This has been implemented in r58521. You can set comments from contextual menu, it's saved to model file. I am not sure how to display them, probably as tooltips or directly in the object shape below label. Any opinions?

I think the ideal would be to be able to add comments independent of objects. Sometimes comments can be about a process that includes several objects. And for such comments it would be nice to have a specific form not yet used by other types of obects (triangle, hexagon, ...).

This make sense.

And to push things even further: it would be nice if these comments then also show up in the Python code...

As comments, good point.

comment:4 in reply to:  3 Changed 5 years ago by martinl

Replying to martinl:

I think the ideal would be to be able to add comments independent of objects. Sometimes comments can be about a process that includes several objects. And for such comments it would be nice to have a specific form not yet used by other types of obects (triangle, hexagon, ...).

Please try out r58557.

comment:5 in reply to:  1 Changed 5 years ago by martinl

Replying to martinl:

In addition, the possibility to add comments would be nice, possibly in the form of a comment object that would be ignored in the model.

This has been implemented in r58521. You can set comments from contextual menu, it's saved to model file. I am not sure how to display them, probably as tooltips or directly in the object shape below label. Any opinions?

Comments related to the commands are now shown as DividedShape, see attachment:modeler-comment.png

Changed 5 years ago by martinl

Attachment: modeler-comment.png added

command with and without a comment, separate comment

comment:6 Changed 3 years ago by martinl

Milestone: 7.0.07.0.5

comment:7 Changed 3 years ago by martinl

Resolution: fixed
Status: newclosed

No activity last 3 years, closing, feel free to reopen if needed.

comment:8 Changed 3 years ago by mlennert

Works great now, thanks !

Forgot that I still had this ticket open...

Note: See TracTickets for help on using tickets.