Opened 6 years ago

Closed 6 years ago

#2019 closed defect (fixed)

v.voronoi Segmentation fault

Reported by: DmitryKolesov Owned by: grass-dev@…
Priority: normal Milestone: 6.4.4
Component: Vector Version: svn-releasebranch64
Keywords: v.voronoi Cc:
CPU: Unspecified Platform: Unspecified

Description

The next lines cause crash report:

echo "7414297.17458|6180640.72109|242
7414836.48276|6179963.8034|817
" | v.in.ascii in=- out=test_tmp x=1 y=2 cat=3  --o

g.region vect=test_tmp

v.voronoi -t in=test_tmp out=test_tmp_v --o
WARNING: Vector map <test_tmp_v> already exists and will be overwritten
Reading sites...
Voronoi triangulation...
Segmentation fault (core dumped)

The version GRASS GIS is

g.version -r
GRASS 6.4.3RC3 (2013) 
Revision: 50937 
Date: 2012-02-25 14:14:51 +0100 (Sat, 25 Feb 2012)

Change History (10)

comment:1 Changed 6 years ago by hamish

is it trying to make a triangle (with area==0) from two points? or were those two points extracted from a larger map having the problem?

comment:2 Changed 6 years ago by hamish

Keywords: v.voronoi added

comment:3 in reply to:  1 ; Changed 6 years ago by DmitryKolesov

Replying to hamish:

is it trying to make a triangle (with area==0) from two points? or were those two points extracted from a larger map having the problem?

Yes, I tryed to create Voronoi diagram from 2 points. But I think (probably wrong): 1) Voronoi diagram of 2 points is possible (the line splits the plain in two half-planes) 2) In any case the module should print a message (the module crashes now).

comment:4 in reply to:  3 Changed 6 years ago by mmetz

Replying to DmitryKolesov:

Replying to hamish:

is it trying to make a triangle (with area==0) from two points? or were those two points extracted from a larger map having the problem?

Yes, I tryed to create Voronoi diagram from 2 points. But I think (probably wrong):

1) Voronoi diagram of 2 points is possible (the line splits the plain in two half-planes)

I agree, this should be possible, but the algorithm (basically written in 1992) does not support this. I guess that the algorithm also does not support points lying on a straight line.

2) In any case the module should print a message (the module crashes now).

Done for trunk in r57182.

comment:5 in reply to:  3 ; Changed 6 years ago by mmetz

Replying to DmitryKolesov:

Replying to hamish:

is it trying to make a triangle (with area==0) from two points? or were those two points extracted from a larger map having the problem?

Yes, I tryed to create Voronoi diagram from 2 points. But I think (probably wrong): 1) Voronoi diagram of 2 points is possible (the line splits the plain in two half-planes)

Right, the same applies to any number of points lying on a straight line. Fixed in trunk r57610.

comment:6 in reply to:  5 Changed 6 years ago by hamish

Replying to mmetz:

Right, the same applies to any number of points lying on a straight line. Fixed in trunk r57610.

great, thanks.

comment:7 Changed 6 years ago by hamish

btw, if it is of interest, I've beeen playing around with some 3D grid creation software lately called Gmsgh, (GPL>=2, standard debian/ubuntu package)

http://www.geuz.org/gmsh/

Hamish

comment:8 Changed 6 years ago by hamish

called Gmsgh

sorry for the typo, make that "Gmsh".

apt-get install gmsh

comment:9 in reply to:  5 ; Changed 6 years ago by neteler

Milestone: 6.4.36.4.4

For the record: fix r57610 (trunk) was backported to relbranch in r57820.

The original crash reported above no longer occurs. Can the ticket be closed?

comment:10 in reply to:  9 Changed 6 years ago by neteler

Resolution: fixed
Status: newclosed
Version: svn-releasebranch64

Replying to neteler: ...

The original crash reported above no longer occurs. Can the ticket be closed?

Closing as fixed.

Note: See TracTickets for help on using tickets.