Opened 11 years ago

Closed 11 years ago

#194 closed defect (fixed)

i.fusion.brovey: remove temp region file?

Reported by: hamish Owned by: grass-dev@…
Priority: minor Milestone: 6.4.0
Component: Default Version: svn-trunk
Keywords: i.fusion.brovey Cc:
CPU: Unspecified Platform: Unspecified

Description

Hi,

just looking through the i.fusion.brovey script I see that the cleanup() section resets the region to the temporary region file instead removing it. Which, AFAICT, is a noop and leaves a saved region file behind.

It in not important that the WIND_OVERRIDE variable is not unset there -- that goes away automatically as soon as the script exits.

?

Hamish

Change History (4)

comment:1 Changed 11 years ago by hamish

Also, it is unclear to me if the "clone current region" step is really needed before setting WIND_OVERRIDE and using the new region file. I notice i.in.spotvgt doesn't bother to do that.

ie can WIND_OVERRIDE legally point to a region wind file which does not yet exist?

Hamish

comment:2 Changed 11 years ago by neteler

AFAIR WIND_OVERRIDE didn't exist when I was writing i.fusion.brovey. Feel free to make appropriate fixes.

Markus

comment:3 in reply to:  1 Changed 11 years ago by glynn

Replying to hamish:

ie can WIND_OVERRIDE legally point to a region wind file which does not yet exist?

It depends upon the situation, but in most cases, no. Anything which tries to read the window (which lots of functions do implicitly) will fail if WIND_OVERRIDE references a non-existent region.

In particular, g.region calls G_get_window() unless -d is given (any command line settings override specific components of the current region), which will fail if WIND_OVERRIDE is set but the region doesn't exit.

comment:4 Changed 11 years ago by hamish

Resolution: fixed
Status: newclosed

fixed in r31829, r31830, r31832.

Hamish

Note: See TracTickets for help on using tickets.