Opened 12 years ago
Closed 6 years ago
#1728 closed defect (wontfix)
r.slope.aspect: possible data type bug?
Reported by: | hamish | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | 7.0.7 |
Component: | Raster | Version: | svn-trunk |
Keywords: | r.slope.aspect | Cc: | |
CPU: | All | Platform: | All |
Description
Hi,
I noticed what might be a bug in the r.slope.aspect code.
If output map type precision (CELL,FCELL,DCELL) is not given, the data_type variable defaults to DCELL*. According to the code comments, data_type should be wrt the input map, not the output map. (* while the output map type defaults to FCELL)
If output map type is given, the data_type is set to the same. The intention is a bit clearer in the legacy code, a just-now change to today's trunk removed some old code around that.
should it be using Rast_map_type() instead? Which type should the allocs called later with data_type be using?
applies to all branches.
a DCELL input map with prec=int specified on the command line does not cause a segfault in my tests, but none the less the code seems a bit muddled...
thanks, Hamish
Change History (4)
comment:1 by , 8 years ago
Milestone: | 7.0.0 → 7.0.5 |
---|
comment:2 by , 8 years ago
Milestone: | 7.0.5 → 7.0.6 |
---|
comment:3 by , 6 years ago
Milestone: | 7.0.6 → 7.0.7 |
---|
comment:4 by , 6 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
No activity.