Opened 7 years ago

Closed 10 months ago

#1728 closed defect (wontfix)

r.slope.aspect: possible data type bug?

Reported by: hamish Owned by: grass-dev@…
Priority: normal Milestone: 7.0.7
Component: Raster Version: svn-trunk
Keywords: r.slope.aspect Cc:
CPU: All Platform: All

Description

Hi,

I noticed what might be a bug in the r.slope.aspect code.

If output map type precision (CELL,FCELL,DCELL) is not given, the data_type variable defaults to DCELL*. According to the code comments, data_type should be wrt the input map, not the output map. (* while the output map type defaults to FCELL)

If output map type is given, the data_type is set to the same. The intention is a bit clearer in the legacy code, a just-now change to today's trunk removed some old code around that.

should it be using Rast_map_type() instead? Which type should the allocs called later with data_type be using?

applies to all branches.

a DCELL input map with prec=int specified on the command line does not cause a segfault in my tests, but none the less the code seems a bit muddled...

thanks, Hamish

Change History (4)

comment:1 Changed 4 years ago by martinl

Milestone: 7.0.07.0.5

comment:2 Changed 3 years ago by neteler

Milestone: 7.0.57.0.6

comment:3 Changed 22 months ago by neteler

Milestone: 7.0.67.0.7

comment:4 Changed 10 months ago by martinl

Resolution: wontfix
Status: newclosed

No activity.

Note: See TracTickets for help on using tickets.