Opened 12 years ago
Closed 8 years ago
#1699 closed defect (fixed)
language setting in wxGUI preferences does not work; could cause GUI crash
Reported by: | cmbarton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 6.4.6 |
Component: | wxGUI | Version: | svn-releasebranch64 |
Keywords: | internationalization | Cc: | |
CPU: | Unspecified | Platform: | Unspecified |
Description
Changing the language in the GUI has no effect. In some cases, the non-functional code causes and error and the GUI to crash. Maris fixed this in GRASS 7. A similar fix is needed here. This is at least a problem on the Mac. Perhaps it works on other systems, but I can't see how it does given the code.
Attachments (1)
Change History (14)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
Maris Nartiss worked out a fix for this on GRASS 7. It is not a simple backport, but should be possible to implement it in GRASS 6.4.3 as the relevant code is similar.
Michael
follow-up: 6 comment:3 by , 12 years ago
comment:4 by , 12 years ago
On Windows, I get on my machine
C:\Programmi\GRASS GIS 6.4.3svn\etc>winlocale it_IT
In init.bat, it picks it up at
if not "%LANG%"=="" goto langset FOR /F "usebackq delims==" %%i IN (`"%GISBASE%\etc\winlocale"`) DO @set LANG=%%i :langset
However, I don't see where an existing LANG setting would be picked up from GRASSRC6.
comment:5 by , 12 years ago
Quick hack if you need to change the language:
edit this file: C:\Programms\GRASS GIS 6.4.3svn\etc\env.bat
and add therein this line (here, to enable English):
set LANG=en
comment:6 by , 12 years ago
Replying to marisn:
Sorry, no time now to analyse init.bat and get it to run on Windows.
I have attached a patch to load the user's LANG setting from GRASSRC6 file. Works for me on XP, I can switch to another language in wxGUI, restart GRASS and it is picked up properly.
comment:8 by , 12 years ago
I'll give this a test this weekend now that I'm compiling again. Thanks for working on it.
Michael
comment:9 by , 12 years ago
This is still not working. I can change the language setting and the setting gets saved in .grassrc6 as LANG=[setting]. But it makes no difference to the GUI.
I've also tried setting language in .profile (export LANG=es, export LC_ALL=es, etc) and it makes no difference at all. Nothing crashing on my Mac, but it only crashed on a spanish colleague's Mac and he is out of town so I cannot ask him to test.
Michael
comment:12 by , 9 years ago
Milestone: | 6.4.3 → 6.4.6 |
---|
comment:13 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Works in GRASS6.4.4 and 7.2svn (windows10)
Confirmed, using current 6.4.svn on an Italian Windows XP, I cannot switch to English.