Opened 13 years ago

Closed 10 years ago

#1288 closed defect (fixed)

g.dirseps breaks non-latin file/folder names on Windows

Reported by: marisn Owned by: grass-dev@…
Priority: critical Milestone: 7.0.0
Component: Default Version: 6.4.1 RCs
Keywords: wingrass, i18n, encoding Cc:
CPU: Unspecified Platform: MSWindows Vista

Description

For some strange reason g.dirseps corrupts file/folder names during slash conversion on Windows Vista running with CP1257 locale. This prevents TCL/Tk GUI from starting as it fails to locate GISRC file.

WinGRASS-6.4.1RC1-1

"Executing: g.dirseps -g 'C:\Users\Māris\.grassrc6'"
C:/Users/MŌris/.grassrc6
"g.dirsteps complete."

Change History (5)

comment:1 by hellik, 13 years ago

Keywords: wingrass added

comment:2 by marisn, 12 years ago

Milestone: 6.4.17.0.0

Related to issue #995 Most likely impossible to fix due to OEM/CP/Unicode coding issues in MS-Windows.

Pushing up to 7.0 to remember about codepage issues in MS-Windows.

comment:3 by wenzeslaus, 10 years ago

Keywords: i18n encoding added

I'm not sure if it makes sense to keep this issue open. It is hard to say where all/some encoding issues may appear and then go and fix them. And new code is being added, so if this issue is kept open to remember, it should be open forever (which does not make sense).

Of course we should keep in mind internationalization issues which are especially occurring on MS Windows. However, I would rather keep tract of individual issues rather then having some general ticket just as a reminder.

Most of the related tickets hopefully captured by these queries:

Done using wiki:TracQuery:

 * [query:?status=assigned&status=new&status=reopened&summary=~localization&summary=~internationalization&summary=~i18n&summary=~L10n&summary=~locale&summary=~locales&summary=~translations&summary=~encoding&order=priority&col=id&col=summary&col=keywords&col=type&col=priority summary]
 * [query:?status=assigned&status=new&status=reopened&description=~localization&description=~internationalization&description=~i18n&description=~L10n&description=~locale&description=~locales&description=~translations&description=~encoding&order=priority&col=id&col=summary&col=keywords&col=type&col=priority description]
 * [query:?status=assigned&status=new&status=reopened&keywords=~localization&keywords=~internationalization&keywords=~i18n&keywords=~L10n&keywords=~locale&keywords=~locales&keywords=~translations&keywords=~encoding&order=priority&col=id&col=summary&col=keywords&col=type&col=priority keywords]

Originally reported issue seems to be resolved as wontfix according to comment:2, so I suggest to close this issue accordingly. But to test this (and perhaps #995) with GRASS 6.4.svn would not harm, probably, since it was reported 3 years ago for GRASS 6.4.1 RC.

comment:4 by wenzeslaus, 10 years ago

Please, somebody, test this on some non-English MS Windows with as many version of GRASS as possible. Please close this ticket if it is not an issue for 7.0 (currently: beta1, beta2, nightly).

comment:5 by marisn, 10 years ago

Resolution: fixed
Status: newclosed

Closing, as GRASS 7 has moved away from the TCL/Tk UI, startup script now is using Python and doesn't call dirseps via shell.

The encoding issues when passing text via CMD remain, but are (and should be) tracked in separate tickets. It is still an issue for the 6.x releases, but wontfix there due to too invasive changes required.

Note: See TracTickets for help on using tickets.