Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#12 closed defect (fixed)

gis.m->Help->About system doesn't work (launches another gis.m instance)

Reported by: neteler Owned by: grass-dev@…
Priority: major Milestone: 6.3.0
Component: Default Version: unspecified
Keywords: Cc: epatton
CPU: Unspecified Platform: Unspecified

Description

Clicking on 'About System' within the gis.m Help menu launches a new set of gis.m windows instead of opening a tcl/tk window with system parameters. The newly created gis manager toolbar says "Tk System Information".

PS: moved here from http://wald.intevation.org/tracker/?func=detail&atid=204&aid=553&group_id=21

Change History (5)

comment:1 in reply to:  description Changed 12 years ago by cmbarton

Replying to neteler:

Clicking on 'About System' within the gis.m Help menu launches a new set of gis.m windows instead of opening a tcl/tk window with system parameters. The newly created gis manager toolbar says "Tk System Information".

PS: moved here from http://wald.intevation.org/tracker/?func=detail&atid=204&aid=553&group_id=21

Is this function worth the trouble of trying to fix? It is very old, heavily patched code. It returns the following information from within the GRASS TclTk? GUI, but I think better information could be had by utilities common to all systems on which GRASS runs.

"Platform " "Operating System " "OS Version " "Processor Type (arch) " "User Name " "Hostname " "Tcl Version " "Name of Executable " "Tcl Version/Patchlevel? " "Full OS ID " "Name of current Script "

Michael

comment:2 Changed 12 years ago by neteler

(copied here from the Mailing list)

This is just a symptom of a larger problem, namely that the Gm::errmsg procedure is defined in gm.tcl, which cannot be "source"d (because doing so will "run" gis.m).

Gm::errmsg belongs in a "library", i.e. a Tcl source file which can be "source"d from other Tcl source files.

Also: gm.tcl calls Gm::errmsg from top-level code at the beginning of the file (the code which copies various g.gisenv settings into $env), although the procedure isn't actually defined until much later in the file. If any of those "catch" statements actually catch an error, the handler will throw an error due to Gm::errmsg being undefined.

-- Glynn Clements <glynn@...>

comment:3 Changed 12 years ago by neteler

Resolution: fixed
Status: newclosed

fixed with Changeset [29647] by cmbarton

comment:4 Changed 12 years ago by hamish

Michael,

r29647 does not appear to be backported to the 6.3 branch. Should it be? any other gis.m bug fixes that need to be backported?

?, Hamish

comment:5 in reply to:  4 Changed 12 years ago by hamish

Replying to hamish:

Michael,

r29647 does not appear to be backported to the 6.3 branch. Should it be? any other gis.m bug fixes that need to be backported?

tip: in the trac SVN browser click on the Rev number next to a directory name to see change history of all files in that dir.

http://trac.osgeo.org/grass/log/grass/trunk/gui/tcltk/gis.m

H

Note: See TracTickets for help on using tickets.