Opened 6 years ago

Closed 6 years ago

#884 closed defect (fixed)

Empty ChangeLog in GEOS 3.7.0alpha

Reported by: Bas Couwenberg Owned by: robe
Priority: blocker Milestone: 3.7.0
Component: Default Version: main
Severity: Unassigned Keywords:


Previous releases has a proper ChangeLog, the file is emty in 3.7.0alpha.

Change History (6)

comment:1 by robe, 6 years ago

Owner: changed from geos-devel@… to robe
Priority: majorblocker

comment:2 by strk, 6 years ago

Regina: git2cl should be available on the machine running make dist A dist-hook rule invokes gen-ChangeLog which should do the generation IFF there's a .git directory. Please check how you generate the dist

comment:3 by robe, 6 years ago

I did have it available. I purposely installed it in fact using

apt install git2cl

Anyway I'll look further why it created a 0 size ChangeLog.

Perhaps git2cl wasn't in path for some reason.

comment:4 by robe, 6 years ago

hmm it's definitely in path, but for some reason running as part of a jenkins job returns a blank ChangeLog file.

running under jenkins account though

git2cl > ChangeLog;

works fine.

Only thing I see is this

Wide character in print at /usr/bin/git2cl line 374, <GEN0> line 2161.
Wide character in print at /usr/bin/git2cl line 374, <GEN0> line 2169.

which I suppose might be tripping it up when running under a jenkins job.

comment:5 by robe, 6 years ago

Okay I found out the problem I think. For some reason under jenkins, when git log is generated I guess it doesn't use --pretty -numstat --summary that git2cl needs.

So to get it to work under jenkins, I did this:

git log --pretty --numstat --summary | git2cl > ChangeLog

You see any reason not to explicitly force that git log behavior?

comment:6 by Regina Obe <lr@…>, 6 years ago

Resolution: fixed
Status: newclosed

In 60fbafd/git:

Revise to call git log explicitly with format suitable for conversion by git2cl.
This is needed because jenkins uses git log format not suitable for git2cl
Closes #884

Note: See TracTickets for help on using tickets.