Distcheck broken on Gitlab-CI after TUT changes

[strk]

Gitlab-CI build started failing after changeset:ee134e7a/git (Update TUT to latest release 2016-12-19) due to this message:

In file included from ../../../tests/unit/geos_unit.cpp:11:0:
../../../tests/unit/tut/tut.hpp:3:30: fatal error: tut/tut_config.hpp: No such file or directory
 #include <tut/tut_config.hpp>
                              ^
compilation terminated.

​https://gitlab.com/geos/libgeos/pipelines/7476486

[mloskot]

I just pushed ​https://git.osgeo.org/gogs/geos/geos/commit/22e93b2a484da58af4756a53fbcfa08f9d8bb254 which should fix it.

When I push, I see some remote messages:

$ git push origin svn-trunk
...
remote: *** Unknown type of update to c626efb67203e092051b8dfcd33080117f682758 (commit)
remote: ***  - no email generated
remote: xargs: trac-admin: No such file or directory
To https://git.osgeo.org/gogs/geos/geos.git
   c626efb6..22e93b2a  svn-trunk -> svn-trunk

BTW, ​https://github.com/OSGeo/geos is out of sync, not been updated for ~10 hours, it's missing your last "Remove trailing blanks in internal geos code" ​https://git.osgeo.org/gogs/geos/geos/commit/d50828b9644980563d09bf490d7ea5b74e95041f

[strk]

Still fails after your commit: ​https://gitlab.com/geos/libgeos/builds/13933744

I hope the trac-admin error is fixed now, see: ​https://git.osgeo.org/gogs/geos/geos-git-hooks/commit/caeb3302448aefae847fe3146e1dc2578c626d82

[strk]

Also, wouldn't it have been simple to add a -I tut/ in CFLAGS ?

[mloskot]

All other builds are green. Perhaps GitLab does partial updates, old tut left, no Idea. Works for me.

[strk]

Do you build with autotools and run make distcheck from a clean tree ?

[strk]

NOTE: I do can reproduce:

In file included from ../../../../tests/unit/geos_unit.cpp:11:0:
../../../../tests/unit/tut/tut.hpp:3:30: fatal error: tut/tut_config.hpp: No such file or directory
compilation terminated.
Makefile:1514: recipe for target 'geos_unit.o' failed
make[5]: *** [geos_unit.o] Error 1
make[5]: Leaving directory '/usr/src/geos/geos-trunk/geos-3.7.0dev/_build/sub/tests/unit'
Makefile:1789: recipe for target 'check-am' failed
make[4]: *** [check-am] Error 2
make[4]: Leaving directory '/usr/src/geos/geos-trunk/geos-3.7.0dev/_build/sub/tests/unit'
Makefile:422: recipe for target 'check-recursive' failed
make[3]: *** [check-recursive] Error 1
make[3]: Leaving directory '/usr/src/geos/geos-trunk/geos-3.7.0dev/_build/sub/tests'
Makefile:471: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory '/usr/src/geos/geos-trunk/geos-3.7.0dev/_build/sub'
Makefile:764: recipe for target 'check' failed
make[1]: *** [check] Error 2
make[1]: Leaving directory '/usr/src/geos/geos-trunk/geos-3.7.0dev/_build/sub'
Makefile:680: recipe for target 'distcheck' failed
make: *** [distcheck] Error 1

How:

git clean -xdf
./autogen.sh && ./configure && make distcheck

[Sandro Santilli <strk@…>]

In 5c8ef06/git:

Distribute all of the new TUT

Fixes #824

[mloskot]

AFAIK make distcheck is not run, you can see yourself in the config files

[strk]

It is, as you can see: ​https://trac.osgeo.org/geos/browser/trunk/.gitlab-ci.yml#L13

Feel free to add that step also to other CI configurations.

[strk]

Also it would be great if you could figure out a way to configure Gitlab-CI to notify state changing events to the author (and committer) of the offending changeset...

[mloskot]

Sorry but i don't need it, i rely on Travis and AppVeyor, never check builders. I'll rather update Travis.yml to do make distcheck

[strk]

Sorry but this approach is not acceptable for a GEOS committer.

You should pay attention to *all* build results. You can see how you broke a build and how the breakage was noticed by one of the bots. Saying that you don't *need* it is false, because you clearly didn't notice how you broke the codebase.

I'm happy if you improve any of the bots (including Travis) but please don't disreguard the others (you can see from the wiki how different bots can have different configurations)

[mloskot]

Sure No problem. I expect you to maintain Travis and AppVeyor configuration too.

[Sandro Santilli <strk@…>]

In c1caa8a/git:

Distribute all of the new TUT

Should fix #824

[Sandro Santilli <strk@…>]

In c1caa8a/git:

Distribute all of the new TUT

Should fix #824

[Sandro Santilli <strk@…>]

In c1caa8a/git:

Distribute all of the new TUT

Should fix #824