Opened 10 years ago

Closed 10 years ago

#351 closed defect (fixed)

Missing includes

Reported by: yabo Owned by: geos-devel@…
Priority: major Milestone:
Component: Default Version: master
Severity: Unassigned Keywords:
Cc:

Description

svn_trunk fails to build on my platform (Linux 64bit, g++ 4.4.3). The errors where about the function isnan and the assert macro.

Here are the changes I had to make :

  • Add <cmath> include to
    • src/geom/GeometryFactory.cpp
    • src/geom/CoordinateArraySequence.cpp
    • src/io/WKTWriter.cpp
  • Add <cassert> include to
    • include/geos/operation/buffer/OffsetCurveVertexList.h
$ svn diff
Index: src/geom/CoordinateArraySequence.cpp
===================================================================
--- src/geom/CoordinateArraySequence.cpp        (revision 2999)
+++ src/geom/CoordinateArraySequence.cpp        (working copy)
@@ -24,6 +24,7 @@
 #include <cassert>
 #include <algorithm>
 #include <vector>
+#include <cmath>
 
 using namespace std;
 
Index: src/geom/GeometryFactory.cpp
===================================================================
--- src/geom/GeometryFactory.cpp        (revision 2999)
+++ src/geom/GeometryFactory.cpp        (working copy)
@@ -37,6 +37,7 @@
 #include <cassert>
 #include <vector>
 #include <typeinfo>
+#include <cmath>
 
 #ifndef GEOS_DEBUG
 #define GEOS_DEBUG 0
Index: src/io/WKTWriter.cpp
===================================================================
--- src/io/WKTWriter.cpp        (revision 2999)
+++ src/io/WKTWriter.cpp        (working copy)
@@ -37,6 +37,7 @@
 #include <string>
 #include <sstream>
 #include <cassert>
+#include <cmath>
 
 using namespace std;
 using namespace geos::geom;
Index: include/geos/operation/buffer/OffsetCurveVertexList.h
===================================================================
--- include/geos/operation/buffer/OffsetCurveVertexList.h       (revision 2999)
+++ include/geos/operation/buffer/OffsetCurveVertexList.h       (working copy)
@@ -27,6 +27,7 @@
 
 #include <vector>
 #include <memory>
+#include <cassert>
 
 // Forward declarations
 namespace geos {

Change History (1)

comment:1 Changed 10 years ago by strk

Resolution: fixed
Status: newclosed

Thanks, committed in r3061

Note: See TracTickets for help on using tickets.