Opened 12 years ago
Closed 12 years ago
#438 closed defect (fixed)
TemplatePopup - Default queryVisible value
| Reported by: | fgagnon | Owned by: | adube |
|---|---|---|---|
| Priority: | trivial | Milestone: | 1.4.0 |
| Component: | widgets | Version: | trunk |
| Keywords: | templatePopup | Cc: | fgagnon, alexandrel@… |
Description
The queryVisible option is documented as defaulting to true but it is currently set to Openlayers default value, false.
The documentation should be respected.
Attachments (1)
Change History (5)
by , 12 years ago
comment:1 by , 12 years ago
| Owner: | changed from to |
|---|
comment:2 by , 12 years ago
| Cc: | added |
|---|---|
| Milestone: | → 1.4.0 |
| Version: | unspecified → trunk |
The current behaviour is "queryVisible: false". Changing this would become a "backward compatibility issue". It seems that changing the doc itself would be best.
But, since this widget is still 'unstable', I'm willing to accept this backward incompatible change. Is 'true' the wanted behaviour we want or should we change the doc ?
Please, comment.
comment:3 by , 12 years ago
| Cc: | added |
|---|
I think that the person writing the doc had it write, querying invisible data seems to be something wierd, even more if you add multiple layers on top of each.
Since it's unstable we should respect the documentation.
thanks.
comment:4 by , 12 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Fixed in r1361. Thanks for the patch.
A reminder : no tabs allowed.
Exactly what it says on the tin.