ExtJs apps lang files are compressed with wrong encoding

[landry]

In the context of building geosource from trunk, the App-mini.js generated file ends up with all utf-8 chars from web-client/src/main/resources/apps/js/OpenLayers/lib/OpenLayers/Lang/fr.js (and probably other langs) are replaced by '?' in the temporary ./target/classes/apps/js/GeoNetwork/lib/GeoNetwork/lang/fr.js file, and in the yui-compressed App-mini.js file.

So all translations strings coming from extjs look broken, they end up in the ui as ??, so for example on geosource homepage i get 'crit??res avanc??es' instead of 'critères avancés'.

The easy fix i've found is to force yuicompressor-maven-plugin to use utf-8 encoding :

Index: web-client/pom.xml =================================================================== --- web-client/pom.xml (revision 9207) +++ web-client/pom.xml (working copy) @@ -78,6 +78,7 @@

<nosuffix>true</nosuffix> <gzip>false</gzip> <force>true</force>

+ <encoding>${project.build.sourceEncoding}</encoding>

<nomunge>true</nomunge> <jswarn>${minify.verbose}</jswarn> <excludes>

By default it seems yuicompressor is supposed to be in utf-8, but in my environment it was not the case.

Note that i havent checked, but it seems only geosource/pom.xml defines project.build.sourceEncoding, so it 'might' break geonetwork. We can aswell hardcode utf-8 here, since all the lang files are in utf-8...

[landry]

Enforce encoding utf8 in yuicompressor

[landry]

After a bit more digging... this is equivalent to passing -Dfile.encoding=UTF-8 to maven, and fixes the issue for me. Otherwise, all accentued/utf chars are replaced by ? in the generated .js.

ie for example in gn.libs.map.js GeoNetwork.lang.fr={featureInfoTooltipTitle:"caract??ristique" vs GeoNetwork.lang.fr={featureInfoTooltipTitle:"caract<C3><A9>ristique" (utf-display in vim, this one is correctly displayed in the browser)

[landry]

​https://github.com/geonetwork/core-geonetwork/commit/9c88deb7e6c01546b28ac04464ac4400e3d0cec1