Select/search/buffer tab conflicts

[andersd]

This happens in both Chrome and IE8 with the demo. To replicate this problem.

1. Open the demo.
2. Zoom to an area.
3. Select a group (polygon) -> creates select tab and highlites group
4. Buffer selected set 20 feet. -> creates buffer tab and highlites group
5. Use search to find owner name cn 'anderson' -> creates owner tab and highlites group

Now you have three tabs for selected set but only one is "connected" to the map highlited group. My suggested change is:

When you execute any feature selection process (search, select, buffer) it should automatically remove the select, search, identify, and buffer tabs. Or at lease clear them out.

[theduckylittle]

This is actually *very* difficult to implement. No "tab" has really any idea about any other tab. They can make sure that no other instances of themselves exists (IE, no more than one identify tab) but the others are all independent operators.

Ways we could potentially fix this:

• Have each service target a different "highlight" layer. This may mean needing to dynamically add MapSources at runtime.
• Create multiple fixed mapsources.

Working on this ticket did reveal another set of bugs. Which I've worked to fix and can be seen in r703.

[andersd]

Used trunk demo with chrome

1. Start
2. zoom in
3. identify a feature (works fine)
4. Select features with triangle

4a. Says "Loading" in Select feature tab then... Error

Error Calling server: TypeError: Object#<Object> has not method 'clearLayerParameters'

5. Then do search and the same error occurs

[theduckylittle]

This is looking increasingly fixed in r715 or newer.

[EliL]

There is a possibly related browser specific tab conflict issue. Using about r711 in IE8.

1. Engage Layer Tools--> Add Polygons
2. Draw a polygon on the map
3. Engage Identify tool
4. Identify by clicking on the map
5. Engage Layer Tools--> Add Polygons <--Identify Tab stay present and active
6. Start drawing polygon <--This works by adding vertices to polygon and Identify Tab updates results each time you click.
7. Try to stop drawing polygon by double clicking <-- Does not work, can't succeed. Can work around by manually closing Identify Tab and then double clicking.

[theduckylittle]

Tabs now clobber themselves. It was a simpler fix than originally envisioned.

r728.

[andersd]

Done with IE8 on trunk demo.

When run you identify after select or search, the select/search tab is removed but the select/search set remains highlited on the map. This works properly between select and search.

[theduckylittle]

r740

[andersd]

Tested with trunk demo on both chrome and ie8. As follows:

1. Start
2. Search
3. Identify <-- cleared both tab and selected map features
4. Select some with a box
5. identify <-- cleared both tab and selected map features