Opened 12 years ago
Closed 12 years ago
#121 closed defect (fixed)
built dojo files do not follow standard dojo convention
| Reported by: | sheppard | Owned by: | theduckylittle |
|---|---|---|---|
| Priority: | minor | Milestone: | 2.6.1 |
| Component: | GeoMOOSE/JS | Version: | 2.6 |
| Keywords: | Cc: |
Description
Current structure:
build/
dojo.js
resources/
nls/
dijit/
icons/
themes/
dojo/ (empty)
Recommended structure:
build/
dojo/
dojo.js
resources/
nls/
dijit/
icons/
themes/
Details:
dojo.js expects to be installed within a dojo/ directory so that it can reference the other namespaces via a relative path. This can be tested with dojo.modulePath('dijit') which returns an nonexistent path in the current build setup. It doesn't seem to break anything yet since we reference the dijit CSS directly, but I'm guessing there are latent issues.
In #120 I am proposing incorporating dojox.widget.Standby, which uses dojo.modulePath to dynamically inject its resources. Thus #120 depends on this ticket.
Attachments (1)
Change History (9)
by , 12 years ago
| Attachment: | paths.patch added |
|---|
follow-up: 6 comment:1 by , 12 years ago
| Status: | new → testing |
|---|
The attachment only updates the paths in geomoose.html and patch_dojo.sh. The following is the primary change but makes a very messy patch:
cd htdocs/build
svn mv dojo.js resources nls dojo/
comment:3 by , 12 years ago
| Status: | testing → needs_work |
|---|
comment:4 by , 12 years ago
| Owner: | set to |
|---|---|
| Status: | needs_work → assigned |
comment:6 by , 12 years ago
| Status: | testing → needs_work |
|---|
Seems to work, but now there are duplicate dojo.js, nls/, and resources/ in both build/ and build/dojo/. I meant to move those but wasn't able to include that in the patch, see comment above.
comment:7 by , 12 years ago
| Status: | needs_work → testing |
|---|
Cool, got it cleaned out. I thought I did this but I must've dreamed that.
pdate build paths