Opened 12 years ago

Closed 12 years ago

#117 closed defect (fixed)

GeoMOOSE bookmark not usable by the Catalog

Reported by: sheppard Owned by: theduckylittle
Priority: major Milestone: 2.6.1
Component: GeoMOOSE/JS Version: 2.6
Keywords: Cc:

Description

Steps to recreate:

  1. Turn on/off some layers.
  2. Trigger GeoMOOSE.bookmark()

Expected result:

The map should stay at the same extent, with the same layers visible.

Actual result:

The map stays at the same extent, but the layers are reset to the mapbook default.

Apparent Cause:

The function renderGroup() in the new GeoMOOSE.Tab.Catalog class checks for the parameters 'on' and 'off' from the URL to determine which layers to change from their defaults. However, the new GeoMOOSE.getBookmarkUrl() function assigns layer information to a single parameter 'layers' that lists all visible layers (regardless of mapbook defaults).

It looks like there was a function called getLayerDifferences() in the old catalog.js that would create the expected 'on' and 'off' parameters for use in the URL.

Proposed Solution:

I'm assuming either Catalog.renderGroup() or GeoMOOSE.getBookmarkUrl() will need to be changed to match the format used by the other, however I am not sure which one.

Change History (7)

comment:1 by sheppard, 12 years ago

Milestone: 2.62.6.1

comment:2 by sheppard, 12 years ago

It looks like the 'on' and 'off' parameters read by GeoMOOSE.Tab.Catalog do not actually change anything. It is not possible in 2.6.0 to change the initial layers via the URL.

comment:3 by theduckylittle, 12 years ago

Owner: set to theduckylittle
Status: newassigned

comment:4 by theduckylittle, 12 years ago

I have this basically working on my local dev box but found a bug with setting Google layers as the default map. Fixing that, then releasing code.

comment:5 by theduckylittle, 12 years ago

Fixed the google layers issue, no resizing/redrawing until *after* it's been added to the map: r901.

comment:6 by theduckylittle, 12 years ago

Status: assignedtesting

And now the real functionality is brought into the new build: r902

comment:7 by sheppard, 12 years ago

Resolution: fixed
Status: testingclosed

Looks good.

Note: See TracTickets for help on using tickets.