CSV driver: memory leak when geometries are supplied but not used

[cdestigter]

• create a CSV datasource
• create a bunch of features with geometries set using SetGeometryDirectly
• use the default creation options (ie discard geometries in CSV output)

The process will leak memory like a sieve.

Using SetGeometry, or using GEOMETRY=AS_WKT or GEOMETRY=AS_XY avoids the problem.

The following code reproduces the memory leak:

#!/usr/bin/python

# Try with `valgrind --leak-check=full /usr/bin/python ./memleak.py`

from osgeo import ogr

ogrdriver = ogr.GetDriverByName("CSV")
ds = ogrdriver.CreateDataSource("memleak.csv")
l = ds.CreateLayer("memleak", options=['GEOMETRY=AS_WKT'])
l_defn = l.GetLayerDefn()

field_def = ogr.FieldDefn("field1", ogr.OFTString)
field_def.SetWidth(100)
assert not l.CreateField(field_def)


for i in xrange(5000):
    if i % 500 == 0:
        print i
    f = ogr.Feature(l_defn)

    g = ogr.CreateGeometryFromWkt('POINT(%.3f %.3f)' % (i, i))
    f.SetGeometryDirectly(g)

    f.SetField("field1", str(i))

    l.CreateFeature(f)
    del f
del l, ds

Our gdal is built from ​https://github.com/koordinates/gdal/tree/trunk-kx

[Robert Coup]

The following code reproduces the memory leak:

if you comment out options=['GEOMETRY=AS_WKT'] obviously...

[cdestigter]

uh, yeah. Trac needs an edit link :)

[cdestigter]

I should also mention I tried ESRI Shapefile and GPKG drivers, and neither exhibited this memory leak.

[Even Rouault]

trunk r27592, branches/1.11 r27593: "Fix OGRFeature::SetGeometryDirectly() and SetGeomFieldDirectly() to free the passed geometry even if the method fails (#5623)"

[cdestigter]

Thanks!