RPC GeoTransform Approximation Wrong
The logic for computing the linear approximation of the RPC (adfGTFromLL) in GDALCreateRPCTransformer() is mixed up. This leads to situations where pixel/line to lat/long conversions do not converge as can be seen in the following example with the attached RPC in a VRT.
$ gdaltransform rpc_5395.vrt -t_srs WGS84
0 0
130.85009097174 -7.59034547771687 0
warmerdam@gdal.cmo:~/pl/planet_common/t965
$ gdaltransform -i rpc_5395.vrt -t_srs WGS84
28.26163232 -27.79853245
1.24353157389123e-05 -2.78099425941036e-05 0
The mapping from 0,0 should be 28.26163232 -27.79853245 but comes out with a weird result which on debugging is due to a lack of convergence.
RPC Demonstrating Issue