MSSQL spatial driver causes IDENTITY INSERT problem

[tamas]

MSSQL spatial driver causes IDENTITY INSERT problem when using -preserve_fid with ogr2ogr

[tamas]

Fixed in r21931 and r21932

[Even Rouault]

Tamas,

is there's a reason for the changesets not being identical in trunk and in 1.8 branch ? I refer to the location of the below test that is found twice in 1.8 branch and just one in trunk, and not at the same place:

    if (poFeature->GetGeometryRef() != poGeom)
    {
        CPLError( CE_Warning, CPLE_NotSupported,
                  "Geometry with FID = %d has been modified.", poFeature->GetFID() );
    }

I've also noted that the "%d" causes a compiler warning since GetFID() returns a long. This should be "%ld"

Best regards,

Even

[tamas]

Replying to rouault:

is there's a reason for the changesets not being identical in trunk and in 1.8 branch ? I refer to the location of the below test that is found twice in 1.8 branch and just one in trunk, and not at the same place:

Not sure what has happened :-O Probably fixed too many things at the same time. Corrected the problems in r21942 and r21943. Thanks for the notification

Tamas