Opened 17 years ago

Closed 16 years ago

Last modified 16 years ago

#1854 closed defect (fixed)

NITF and 1-bit images

Reported by: Even Rouault Owned by: warmerdam
Priority: normal Milestone: 1.5.0
Component: GDAL_Raster Version: svn-trunk
Severity: normal Keywords: nitf 1-bit
Cc:

Description

I've run GDAL on a number of NITF 2.1 images from ​http://www.gwg.nga.mil/ntb/baseline/software/testfile/Nitfv2_1/scen_2_1.html.

The following 1-bit images make GDAL segfault or give errors with valgrind :

  • i_3034c.ntf
  • ns3034d.nsf
  • i_3034f.ntf

I'm enclosing a patch that fixes the case of i_3034c.ntf. I'm not sure if this is right way to fix it but openev will display a green arrow on a red background as expected. The 2 other cases are not addressed by the patch.

Attachments (4)

gdal_svn_trunk_fix_for_i_3034c_ntf_bug1854.patch​ (1.7 KB ) - added by Even Rouault 17 years ago.
i_3034c.ntf​ (933 bytes ) - added by Even Rouault 17 years ago.
ns3034d.nsf​ (937 bytes ) - added by Even Rouault 17 years ago.
i_3034f.ntf​ (948 bytes ) - added by Even Rouault 17 years ago.

Download all attachments as: .zip

Change History (6)

by Even Rouault, 17 years ago

Attachment: gdal_svn_trunk_fix_for_i_3034c_ntf_bug1854.patch​ added

by Even Rouault, 17 years ago

Attachment: i_3034c.ntf​ added

by Even Rouault, 17 years ago

Attachment: ns3034d.nsf​ added

by Even Rouault, 17 years ago

Attachment: i_3034f.ntf​ added

comment:1 by warmerdam, 16 years ago

Milestone: → 1.5.0
Resolution: → fixed
Status: new → closed

Patch applied in trunk as r12927 with a few adjustments (added NBITS metadata, slightly improved error reporting).

Added test with i_3034c.ntf in the test suite (r12926).

comment:2 by Even Rouault, 16 years ago

Additionnal fix for handling 1-bit uncompressed NITF images with NITF_IC=NM (for ns3034d.nsf and i_3034f.ntf) commited in trunk in r14423 and test for the 2 images added in the test suite in r14424

Note: See TracTickets for help on using tickets.