Opened 16 years ago

Closed 7 years ago

Last modified 7 years ago

#1265 closed enhancement (fixed)

Code to fix transctions in OGR PostgreSQL driver

Reported by: amagnum2@… Owned by: Even Rouault
Priority: normal Milestone: 2.0.0
Component: OGR_SF Version: unspecified
Severity: normal Keywords: PostgreSQL
Cc: Markus Neteler, warmerdam, Mateusz Łoskot

Description (last modified by warmerdam)

I have attached the code that would allow for PGSQL transactions. The existing behaviour is that the tranactions work, but sometimes they are commited premateurely. I don't think this affects ogr2ogr or ogrinfo but it does affect people that are trying to do things such as inserting data and then selecting that data, or anything that is more complex than populatinga table.

Note that in order to start a transaction, there must be at least one layer in the database, since the call to begin transaction is in the layer object.

Attachments (2)

ogrpgdatasource.cpp (48.2 KB ) - added by amagnum2@… 16 years ago.
ogrpgdatasource.cpp
ogrpglayer.cpp (36.8 KB ) - added by amagnum2@… 16 years ago.
ogrpglayer.cpp

Download all attachments as: .zip

Change History (13)

by amagnum2@…, 16 years ago

Attachment: ogrpgdatasource.cpp added

ogrpgdatasource.cpp

by amagnum2@…, 16 years ago

Attachment: ogrpglayer.cpp added

ogrpglayer.cpp

comment:2 by warmerdam, 15 years ago

Cc: warmerdam added
Description: modified (diff)
Milestone: 1.5.0
Owner: changed from warmerdam to Mateusz Łoskot
Priority: highestnormal
Severity: minornormal

Matuesz,

When things are settled down, I'd like this patch considered for 1.5.0.

comment:3 by Mateusz Łoskot, 15 years ago

Cc: Mateusz Łoskot added

comment:4 by Mateusz Łoskot, 15 years ago

Keywords: PostgreSQL added

comment:5 by warmerdam, 15 years ago

Milestone: 1.5.01.6.0

To high risk to do this late in 1.5.

comment:6 by Markus Neteler, 15 years ago

Cc: Markus Neteler added; neteler@… removed

comment:7 by warmerdam, 11 years ago

Milestone: 1.6.4

Removing milestone.

comment:8 by Jukka Rahkonen, 8 years ago

Could it be possible to get some prompt examples about situations when transactions fail with the current driver?

comment:9 by Even Rouault, 8 years ago

I might work on this in the future by introducing datasource level transaction API

comment:10 by Even Rouault, 7 years ago

Owner: changed from Mateusz Łoskot to Even Rouault

comment:11 by Even Rouault, 7 years ago

Milestone: 2.0
Resolution: fixed
Status: newclosed

RFC 54 committed in r28601

comment:12 by Even Rouault, 7 years ago

Milestone: 2.02.0.0

Milestone renamed

Note: See TracTickets for help on using tickets.