Opened 15 years ago

Closed 14 years ago

Last modified 14 years ago

#255 closed defect (fixed)

Build.xml needs to specify encoding for call to YUICompressor

Reported by: tomfukushima Owned by: madair
Priority: P1 Milestone: Future
Component: Core Version: 1.1.1
Severity: Major Keywords:
Cc: Browser: All
External ID: Operating System: All
state: New

Description

YUICompressor is used to generate the compressed .js file. It needs to specify the char encoding of UTF-8 otherwise it will default to the host computers default encoding.

To see the problem, search for "SelectionPanel" in the resultant fusionSF-compressed.js file. The second occurrence of this will have a corrupt French string. Applying the attached patch will fix the problem. All I did was add the charset argument and specified UTF-8; I don't know ant so I don't know if what I did was correct or not, but when I ran it, the compressed file looked good.

The patch file changes the charset in two other places where YUICompressor is used; I'm not sure if these two other places should have the change or not.

Attachments (1)

build.xml.patch (1004 bytes ) - added by tomfukushima 15 years ago.

Download all attachments as: .zip

Change History (4)

by tomfukushima, 15 years ago

Attachment: build.xml.patch added

comment:1 by madair, 14 years ago

Status: newassigned

test comment for Trac updates

comment:2 by madair, 14 years ago

Resolution: fixed
Status: assignedclosed

fixed at rev 1913

comment:3 by tomfukushima, 14 years ago

I noticed that r1913 puts a hardcoded location in for PHP (C:\ms4w\Apache\cgi-bin\php.exe). Won't this break things? Esp on Linux.

Note: See TracTickets for help on using tickets.