regress failures - can we not overwrite loader error file?

[robe]

I'm getting a lot of mingw64 erros on loader. One looks like just a rounding issue.

 PostgreSQL 9.1.3 on x86_64-w64-mingw32, compiled by x86_64-w64-mingw32-gcc.e
(GCC) 4.4.7 20110510 (prerelease) [svn/rev.173611 - mingw-w64/oz], 64-bit
 Postgis 2.0.0beta4 - r9521 - 2012-03-22 02:03:16
   GEOS: 3.3.3dev-CAPI-1.7.3
   PROJ: Rel. 4.8.0, 6 March 2012

Running tests

 loader/Point ....................... ok
 loader/PointM ....................... ok
 loader/PointZ ....................... ok
 loader/MultiPoint ....................... ok
 loader/MultiPointM ....................... ok
 loader/MultiPointZ ....................... ok
 loader/Arc ....................... ok
 loader/ArcM ....................... ok
 loader/ArcZ ....................... ok
 loader/Polygon ....................... ok
 loader/PolygonM ...... failed ( geog test: running shp2pgsql output: /tmp/pg
reg/loader.err)
 loader/PolygonZ ...... failed ( geog test: running shp2pgsql output: /tmp/pg
reg/loader.err)
 loader/TSTPolygon ......... ok
 loader/TSIPolygon ......... ok
 loader/TSTIPolygon ......... ok
 loader/PointWithSchema ..... ok
 loader/NoTransPoint ......... ok
 loader/NotReallyMultiPoint .... failed (wkt test: diff expected obtained: /t
pgis_reg/test_18_diff)
 loader/MultiToSinglePoint ... failed ( wkt test: running shp2pgsql output: /
/pgis_reg/loader.err)
 loader/ReprojectPts .... failed ( wkt test: running shp2pgsql output: /tmp/p
_reg/loader.err)
 loader/ReprojectPtsGeog .... failed ( wkt test: running shp2pgsql output: /t
pgis_reg/loader.err)
 loader/Latin1 .... ok
 binary .. ok
 regress .. ok
 regress_index .. ok
 regress_index_nulls .. ok
 lwgeom_regress .. ok
 regress_lrs .. ok
 removepoint .. ok
 setpoint .. ok
 simplify .. ok
 snaptogrid .. ok
 summary .. ok
 affine .. ok
 empty .. ok
 measures .. ok
 legacy .. ok
 long_xact .. ok
 ctors .. ok
 sql-mm-serialize .. ok
 sql-mm-circularstring .. ok
 sql-mm-compoundcurve .. ok
 sql-mm-curvepoly .. ok
 sql-mm-general .. ok
 sql-mm-multicurve .. ok
 sql-mm-multisurface .. ok
 polyhedralsurface .. ok
 polygonize .. ok
 postgis_type_name .. ok
 out_geometry .. ok
 out_geography .. ok
 in_gml .. ok
 in_kml .. ok
 iscollection .. ok
 regress_ogc .. ok
 regress_ogc_cover .. ok
 regress_ogc_prep .. ok
 regress_bdpoly .. ok
 regress_proj .. ok
 regress_management .. ok
 dump .. ok
 dumppoints .. ok
 wmsservers .. ok
 wkt .. ok
 wkb .. ok
 tickets .. ok
 typmod .. ok
 remove_repeated_points .. ok
 split .. ok
 relate .. ok
 bestsrid .. ok
 concave_hull .. ok
 hausdorff .. ok
 regress_buffer_params .. ok
 offsetcurve .. ok
 relatematch .. ok
 isvaliddetail .. ok
 sharedpaths .. ok
 snap .. ok
 node .. ok
 unaryunion .. ok
 clean .. ok
 relate_bnr .. ok
 in_geojson .. ok
 uninstall .. ok (3855)

Run tests: 85
Failed: 6
make: *** [check] Error 6

Anyrate I don't care so much about getting the errors as much as not knowing what they are. the shp2pgsql overwrite the loader.err file so can't tell what the errors are if they are harmless or not.

The multi to single point one looks like a rounding issue

--- loader/NotReallyMultiPoint-w.select.expected	2011-03-18 12:24:33 -0400
+++ /tmp/pgis_reg/test_18_out	2012-03-21 22:11:29 -0400
@@ -38,7 +38,7 @@
 MULTIPOINT(605633.269658534 771823.459750208)
 MULTIPOINT(318054.396825439 406677.968765208)
 MULTIPOINT(606814.490943 683559.837390652)
-MULTIPOINT(427202.24558416 526355.921118875)
+MULTIPOINT(427202.24558416 526355.921118876)
 MULTIPOINT(585605.654583162 428734.299958661)
 MULTIPOINT(348498.220290712 696622.254661199)
 MULTIPOINT(447753.888233448 552268.218021069)

[pramsey]

Run the ./run_test script directly so you can specify the precise test you want to run. That's how I worked around this limitation. Can we close this out or punt forward? It's not going to be a 2.0.0 fix.

[robe]

sorry didn't realize I had it under 2.0.0. Punted forward.

[robe]

Update: PolygonM and PolygonZ are no longer failing. This one is scray because it has to do with my script and when it fails the loader (both commandline and shape loader fail with my big tract polygons).

This one - rounding issue.

--- loader/NotReallyMultiPoint-w.select.expected	2011-03-18 12:24:33 -0400
+++ /tmp/pgis_reg/test_1_out	2012-04-04 15:12:46 -0400
@@ -38,7 +38,7 @@
 MULTIPOINT(605633.269658534 771823.459750208)
 MULTIPOINT(318054.396825439 406677.968765208)
 MULTIPOINT(606814.490943 683559.837390652)
-MULTIPOINT(427202.24558416 526355.921118875)
+MULTIPOINT(427202.24558416 526355.921118876)
 MULTIPOINT(585605.654583162 428734.299958661)
 MULTIPOINT(348498.220290712 696622.254661199)
 MULTIPOINT(447753.888233448 552268.218021069)

— another rounding issue —

--- loader/MultiToSinglePoint-w.select.expected	2011-03-18 12:24:33 -0400
+++ /tmp/pgis_reg/test_1_out	2012-04-04 15:15:18 -0400
@@ -38,7 +38,7 @@
 POINT(605633.269658534 771823.459750208)
 POINT(318054.396825439 406677.968765208)
 POINT(606814.490943 683559.837390652)
-POINT(427202.24558416 526355.921118875)
+POINT(427202.24558416 526355.921118876)
 POINT(585605.654583162 428734.299958661)
 POINT(348498.220290712 696622.254661199)
 POINT(447753.888233448 552268.218021069)

loader/ReprojectPts — passes if i run it standalone but fails if run in battery of tests. Have no clue why.

loader/ReprojectPtsGeog — also passes if run standalone but not in battery.

Should I be concerned. Can we round these more so I can pass with flying colors?

[pramsey]

I think we should remove the -w tests, we can't round in them, and they are an ancient and unwanted flag in any event.

[robe]

I'm fine with that. those extra -w files have always confused me.

[strk]

Robe: was this fixed by r9870 ?

[robe]

yah sorry forgot to close out.