Opened 16 years ago

Closed 16 years ago

#2633 closed defect (fixed)

Flaw in findTag() in maptemplate.c.

Reported by: sdlime Owned by: sdlime
Priority: normal Milestone: 5.2 release
Component: MapServer C Library Version: unspecified
Severity: normal Keywords:
Cc: dmorissette

Description

The function searches for "[name " before "[name]" which can cause problems. For example, consider the text:

[shpext][shpext expand=1000 precision=0]

The findTag() function skips the first occurrence. I can see why we need to detect both cases. I think we need to test for both and figure out which comes first some how. Perhaps we test for "[name" and look at the next character, if a "[" or a " " then return, if not look again. Some sort of a while(!done) { } loop would suffice.

Steve

Change History (3)

comment:1 by dmorissette, 16 years ago

Um... good catch! I agree that your proposed fix seems like the best way to go.

comment:2 by sdlime, 16 years ago

Status: newassigned

Cool, I'll take care of it since I have a test case handy...

Steve

comment:3 by sdlime, 16 years ago

Resolution: fixed
Status: assignedclosed

Fixed in r7628. - Steve

Note: See TracTickets for help on using tickets.