Reset error list before (after?) GC map object

[project10]

I noticed that, under WxS wrapper (mapscript within long-running php process), that the error list was not reset between requests and would continue to accumulate.

Adding msResetErrorList() to msFreeMap() in mapobject.c fixes the issue for me. Perhaps there is a more elegant place to put this call, though.

[warmerdam]

I'm not sure it is prudent to address this in 5.0.1.

I think two issues arise. One is whether we should automatically clear the error stack in some strategic locations to avoid accumulating lots of old messages. The other is whether msResetErrorList() ought to be exposed to mapscript.

I'll drop a line to -dev to see if there is other input before I proceed.

[project10]

MapScript already exposes functions to reset the error list, which work as expected for me. Downgrading the severity on this ticket.

Leaving open as it seems that MapServer running under MapScript should not slowly accumulate old error messages if not explicitly cleared.

[warmerdam]

Added docs for msResetErrorList() in mapscript.txt docs (r7196).

[dmorissette]

Do we want to add a call to msResetErrorList() in msFreeMap() for 5.6?

[dmorissette]

I'll close WONTFIX. I'm worried that resetting the error list in msFreeMap() could cause side-effects to scripts using multiple map objects. Let's leave it up to the script itself to decide when is the right time to reset the error list.