Opened 17 years ago

Closed 14 years ago

#2170 closed defect (fixed)

Remove deprecated scale and symbol.style members in PHP MapScript

Reported by: dmorissette Owned by: dmorissette
Priority: normal Milestone: 6.0 release
Component: MapScript-PHP Version: 5.0
Severity: normal Keywords:
Cc: aboudreault, sdlime

Description

In r6381 (ticket #2119, RFC-26), we have renamed scale to scaledenom and renamed symbol style to pattern. All the old members have been kept and marked deprecated in php_mapscript.c and the associated docs (mapscript/php3/README).

This ticket is to remind us to remove those members in MapServer 5.2 or 5.4.

Change History (9)

comment:1 by dmorissette, 17 years ago

OOpps... I had forgotten the transparency keyword that has been renamed opacity and deprecated. Old refs to transparency will need to be removed at the same time (see r6382).

comment:2 by hobu, 17 years ago

Because of the nature of SWIG mapscript, layer.scale or layer.transparency are no longer valid and we weren't able to gracefully deprecate them.

comment:3 by tomkralidis, 16 years ago

Any update on this one?

comment:4 by dmorissette, 16 years ago

Milestone: 5.2 release5.4 release

Probably a bad idea to remove those at this time for 5.2. Pushing to 5.4.

comment:5 by dmorissette, 15 years ago

Cc: aboudreault added
Milestone: 5.4 release6.0 release
Owner: changed from mapserverbugs to dmorissette

6.0 would be a great time to do this cleanup.

comment:6 by aboudreault, 14 years ago

Cc: sdlime added

Steve, I'm going to remove all deprecated properties in php mapscript (for 6.0). Do you have any objection on this ?

comment:7 by aboudreault, 14 years ago

oh, and I'll drop the php4 support.

comment:8 by aboudreault, 14 years ago

oups, I meant php3, my cleanup shouldn't break anything related to php4 (don't really know if the current extension build with php4)

comment:9 by aboudreault, 14 years ago

Resolution: fixed
Status: newclosed

All deprecated class properties have been removed from php/mapscript in r9695. Documentation has been updated in r9696. All removed properties are listed in mapscript/php3/README and a note has been added in the MIGRATION_GUIDE.TXT file
A php3 cleanup has been done in r9699.

I'm going to close this ticket, just reopen it if there is something wrong.

Note: See TracTickets for help on using tickets.