Ticket #2169 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

Do we still need 'isachild' member in styleObj?

Reported by: dmorissette Assigned to: dmorissette
Priority: normal Milestone: 5.0 release
Component: MapScript-SWIG Version: 5.0
Severity: normal Keywords:
Cc: unicoletti, tamas

Description

While working on #302, I noticed the isachild member in the styleObj that doesn't seem to be used any more (or anyway its value doesn't seem to be used anywhere based on a quick grep): 

#ifndef SWIG
  /* Whether the style is within a class MS_TRUE or MS_FALSE.
   * If true, then memory deallocation is handled by the class
   * if false, then memory deallocation must be handled by the
   * application.
   */
  int isachild;
#endif

Can we remove this member? Is it still used by any of the SWIG wrappers?

Change History

07/23/07 10:32:05 changed by dmorissette

  • cc set to umberto, tamas.

07/31/07 23:40:00 changed by sdlime

style.i still references that attribute. However, it only sets it and there is no code that relies on the value that I can find. So, I think it could be removed (style.i would need updating then).

Steve

08/01/07 10:15:30 changed by dmorissette

  • owner changed from sdlime to dmorissette.
  • cc changed from umberto, tamas to unicoletti, tamas.

Sounds good, taking this ticket and removing isachild now.

08/01/07 10:15:35 changed by dmorissette

  • status changed from new to assigned.

08/01/07 10:24:33 changed by dmorissette

  • status changed from assigned to closed.
  • resolution set to fixed.

Done. styleObj.isachild member removed in r6434 (will be in 5.0.0-beta2).