Opened 17 years ago

Closed 17 years ago

#2169 closed defect (fixed)

Do we still need 'isachild' member in styleObj?

Reported by: dmorissette Owned by: dmorissette
Priority: normal Milestone: 5.0 release
Component: MapScript-SWIG Version: 5.0
Severity: normal Keywords:
Cc: unicoletti, tamas

Description

While working on #302, I noticed the isachild member in the styleObj that doesn't seem to be used any more (or anyway its value doesn't seem to be used anywhere based on a quick grep): 

#ifndef SWIG
  /* Whether the style is within a class MS_TRUE or MS_FALSE.
   * If true, then memory deallocation is handled by the class
   * if false, then memory deallocation must be handled by the
   * application.
   */
  int isachild;
#endif

Can we remove this member? Is it still used by any of the SWIG wrappers?

Change History (5)

comment:1 by dmorissette, 17 years ago

Cc: umberto tamas added

comment:2 by sdlime, 17 years ago

style.i still references that attribute. However, it only sets it and there is no code that relies on the value that I can find. So, I think it could be removed (style.i would need updating then).

Steve

comment:3 by dmorissette, 17 years ago

Cc: unicoletti added; umberto removed
Owner: changed from sdlime to dmorissette

Sounds good, taking this ticket and removing isachild now.

comment:4 by dmorissette, 17 years ago

Status: new → assigned

comment:5 by dmorissette, 17 years ago

Resolution: → fixed
Status: assigned → closed

Done. styleObj.isachild member removed in r6434 (will be in 5.0.0-beta2).

Note: See TracTickets for help on using tickets.