Opened 9 years ago

Closed 9 years ago

#801 closed enhancement (fixed)

Request for change the status bar to reflect the layer selected

Reported by: bscott Owned by: waltweltonlair
Priority: low Milestone: 2.1
Component: AJAX Viewer Version: 2.0.2
Severity: trivial Keywords:
Cc: External ID: 1189957

Description

Actually, the status bar in the ajax viewer only shows the amount of features selected. It would be great if it showed the name of the selected layer also. If there is many features selected on different layers, the behavior stays the same as actually.

nabble thread: http://www.nabble.com/Request-for-change-the-status-bar-to-reflect-the-layer-selected-td21051252.html

Attachments (1)

patch_statusbar.patch (3.1 KB) - added by bscott 9 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 9 years ago by tomfukushima

Nice! I'm going to show this to a product designer for review.

comment:2 Changed 9 years ago by tomfukushima

Sorry, I meant the above comment for ticket #800. This change looks good, I'll try to get it in.

comment:3 Changed 9 years ago by tomfukushima

I tested this out and would like to request the following changes before I submit.

  1. Check to make sure selLayers is not null before using it (that is, change line "if(selLayers.length ==1)" to "if(selLayers!=null && selLayers.length...".
  2. Put up a tooltip when the user floats the mouse over the area that displays the selection count. This is required now for the cases of long layer names which will make it so that some of the text is not visible. I realize that you could select the text area and scroll the text using the mouse, but this is not user friendly. Alternatively, if we could resize the status bar areas, that might be another solution. Of course, there might be another way to solve this too.

Thanks, Tom

comment:4 Changed 9 years ago by bscott

Hi Tom, I added the test fir selLayers != null and i added tooltips for it. I have also added tooltips for the first items in the statusbar ( the x,y position), it does not hurt :)

And as you suggested i've made the with a little bigger ( 300 instead of 200 pixels)

Changed 9 years ago by bscott

Attachment: patch_statusbar.patch added

comment:5 Changed 9 years ago by tomfukushima

It's strange, but after applying this patch nothing shows up in the "selected features" section of the status bar. It is blank. To verify that the patch was applied correctly, I created a patch from my source after applying yours and found that the only differences in the patch were the revisions of the files that the patches were applied against. For en I was at revision 3523, while you were at 3498. For mainframe.templ, me: 3523, you: 3516. For statusbar.templ, me: 3523, you: 3516. Can you see anything that would cause the problem that I'm seeing? BTW, the tooltip comes up for the (x,y position).

comment:6 Changed 9 years ago by bscott

I Tom, I have notice something on my pc also. When we add new stuff in the localized "en" file, the modification is not applied directly. I think there is some caching somewhere that cause this. I've tried plenty of thing:

Restart mapguide server : did not work Restart IIS : did not work Reboot the pc : this one worked, ouf!

Bruno

comment:7 Changed 9 years ago by tomfukushima

Thanks. Actually, it was because I forgot to replace the en file on my test machine. Sorry, my mistake. It works for me now.

comment:8 Changed 9 years ago by tomfukushima

External ID: 1189957

comment:9 Changed 9 years ago by waltweltonlair

Owner: set to waltweltonlair
Status: newassigned

comment:10 Changed 9 years ago by waltweltonlair

Resolution: fixed
Status: assignedclosed

Fixed in the trunk stream with submission https://trac.osgeo.org/mapguide/changeset/3734.

Thanks bscott for providing this patch.

Note: See TracTickets for help on using tickets.