Opened 12 years ago

Closed 12 years ago

#2144 closed defect (fixed)

Closing taskpane does not work when no taskbar

Reported by: bscott Owned by:
Priority: low Milestone: 2.5
Component: AJAX Viewer Version: 2.4.0
Severity: trivial Keywords:
Cc: External ID:

Description

If you don't have the taskbar displayed in your basic layout It is not possible to close the taskpane.

Trivial to fix, i've included the patch to fix this.

Bruno

Attachments (1)

taskbar.templ.patch (443 bytes ) - added by bscott 12 years ago.

Download all attachments as: .zip

Change History (6)

by bscott, 12 years ago

Attachment: taskbar.templ.patch added

comment:1 by jng, 12 years ago

Is something missing? I can't see any difference with this patch applied.

comment:2 by bscott, 12 years ago

To reproduce the problem, you have to remove the taskbar from your basic layout. Then when you run a command that open the taskpane ( help, buffer,...). On the top of the taskpane you have the close button. Clicking this button has no effect because the code try to access the taskbar's divRefresh element (it does not exist in that context). This append just before the call to the CloseTaskBar. A little test on the divRefresh element fix this issue.

comment:3 by jng, 12 years ago

I guess this is my problem because I cannot see this <close button that does nothing> when I invoke a TaskPane command on a WebLayout where TaskBar = Off

Note that TaskPane = On when I tried this, should this be off as well?

comment:4 by bscott, 12 years ago

ok, i got it, we should rename this ticket to Closing taskpane does not work when no toolbar

Lets try again, Keep the taskbar and taskpane , but remove the toolbar from the basic layout. Then you can reproduce the problem.

Sorry, i was a bit messy with all these patches :) Bruno

comment:5 by jng, 12 years ago

Resolution: fixed
Status: newclosed

Yep, I see it now.

Fixed r7124. Thanks for the patch.

Note: See TracTickets for help on using tickets.