Access to the CsMap coordinate system dictionary files is not correctly protected by the Mg API

[baertelchen]

See the CriticalSection.h in \MgDev\OS\Common\CoordinateSystem:

There exists the class CustomCriticalSection and a static variable of that class is defined, too.

static CustomCriticalSection CriticalClass;

This one has internal linkage, however; i.e. each object file this header is compiled into, will have it's own instance of CriticalClass.

The problem surfaces, when trying to read all available coordinate systems from multiple threads. The Mg API will eventually fail, because CsMap is not thread-safe.

Originally, only one instance existed.

The attached patch moves the CriticalClass into a separate source file and declares it [extern] in the header.

[baertelchen]

Patch that adds the CriticalSection implementation in its own file, updates to the makefile and the VS project file

[brucedechant]

Submitted r5295