"Help" in login site doesn't work

[ChristineBao]

Report from Autodesk QA:

Steps:

1. ​http://cadcmapqa23/mapguide2011/mapadmin/login.php[[BR]]
2. Click Help button.
   

Results:
Login.php was invoked by a new browsers with one warning message.

Expected results:
Help document for site administrator shold be invoked.

Workaround: N
Regression: N

[ChristineBao]

Tech assessment:
Help.php check the session using code LoadSessionVars().
In the LoadSessionVars() function, it will try to refresh the session by login again

       try
       {
           //do something...

           // Initialize web tier with the site configuration file.
            MgInitializeWebTier( $webConfigFile );

            // Set up user info
            $userInfo = new MgUserInformation();
            $userInfo->SetMgSessionId( $adminSession );
            $userInfo->SetClientAgent( $clientAgent );
            $userInfo->SetClientIp( $clientIp );

            // Create a Site object and open the Site Server.
            $site = new MgSite();
            $site->Open( $userInfo );
        }
        catch( AuthenticationFailedException $e )
        {
            LogoutWithAuthenticationFailedException();
        }

User hasn't logged in when visting the login page, thus an authentication exception thrown out.

To fix this defect, ignore LoadSessionVars() when the help Id is "HelpDocs/about_sites_and_servers.htm".

[ChristineBao]

Attach a patch for fixing it.