Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#1327 closed enhancement (fixed)

Maestro: Add Find and Replace Functionality to XML Editor

Reported by: crispinatime Owned by: jng
Priority: low Milestone: Maestro-3.0
Component: Maestro Version: 2.0.0
Severity: trivial Keywords:
Cc: External ID:

Description

This suggestion adds a 'Find' and 'Replace' edits and functionality to the XML editor control which then nicely appears in assorted places in the Maestro UIs.

The current implementation could certainly do with a 3rd party review as the techniques (e.g. using RegEx and adding support in the constructor) were defined for a certain need and possibly could be more usefully deployed with a wider consideration

Attachments (2)

1327.zip (20.6 KB ) - added by crispinatime 14 years ago.
Diffs
1327.patch (71.8 KB ) - added by crispinatime 14 years ago.
Patch (complete replacement for Diffs in ZIP)

Download all attachments as: .zip

Change History (6)

by crispinatime, 14 years ago

Attachment: 1327.zip added

Diffs

comment:1 by jng, 14 years ago

I can't apply these patches. What source did you create these patches from?

by crispinatime, 14 years ago

Attachment: 1327.patch added

Patch (complete replacement for Diffs in ZIP)

comment:2 by crispinatime, 14 years ago

As the changes in the .patch file come from our local source the edits are tagged with "1SPATIAL START" and END to help me find/manage my changes when there are SVN updates - obviously if you review/edit then these comments should not go into trunk!

comment:3 by jng, 14 years ago

Resolution: fixed
Status: newclosed

Fixed in r4810

I'm not quite certain about the new EditorInterface APIs, but since #1328 has a dependency on this patch, I'll put that in before considering any refactoring.

comment:4 by jng, 14 years ago

Milestone: Maestro-2.1Maestro-3.0

Milestone Maestro-2.1 deleted

Note: See TracTickets for help on using tickets.