Path corrections and small template extensions in mapviewerphp/layerdefinitionfactory.php

[gabrimonfa]

All path in mapviewerphp/layerdefinitionfactory.php pointing to ../../viewerfiles should be corrected to ../viewerfiles

CreateAreaRule can be extended to accept two more parameters, $strokeThickness and $strokeColor. CreateLineRule can be extended to accept one more parameter, $strokeThickness

This two last modifications require to modify accordingly also the areaRule and lineRule templates in viewerfiles.

All attached unified diff files refer to <file>_20100226.php (the original one) and <file>.php (the modified one)

[gabrimonfa]

diff between the current version (ayerdefinitionfactory_20100226.php) and the proposed one

[gabrimonfa]

trivial template extension to accept also $strokeThickness and $strokeColor

[gabrimonfa]

trivial template extension to accept also $strokeThickness

[tomfukushima]

Thanks for this but what is this fixing and how can we reproduce the problem that it is fixing?

[gabrimonfa]

Well, paths are wrong since the directory "viewerfiles" is in the parent directory, not in the parent of the parent ("mapviewerphp" and "viewerfiles" are sibling).

The enhancement allows to specify stroke thickness and color that are hard coded in the templates (we use it to have different colors redlining). Thus I propose to modify the templates and the functions in layerdefinitionfactory.php that instantiate the templates

[tomfukushima]

Here is some info that will be useful for reproducing this from an email from Gabriele to mapguide-internals: redlining in php appears to be broken, since template files are not found.

[brucedechant]

The changes look good. However, the createlayer.php file will also need to be updated to work with these changes.

Also, I would like to change the order of parameters from what you had:

static function CreateLineRule($legendLabel, $filter, $strokeThickness, $color)

To:

static function CreateLineRule($legendLabel, $filter, $color, $strokeThickness)

This way the new parameter is on the end.

[brucedechant]

I take back my suggestion on changing the order of the parameters as the order you have matches the schema.

[brucedechant]

Fixed path. r5383

[gabrimonfa]

Thank you for working on this. For me it's ok to close this enhancement.

[brucedechant]

I would like to update this ticket to refer to only the path issue as it is a defect. Could you please create a new ticket with your enhacement ideas?

[gabrimonfa]

Sure, I would have differentiated the defect and the enhancement from the beginning. I've opened ​http://trac.osgeo.org/mapguide/ticket/1522

that addresses the "enhancement part"

[brucedechant]

Closing this ticket as the defect has been fixed and the enhancement has been moved to ticket 1522