Ticket #1227 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Return to home page task button fails in MGOS 2.1

Reported by: iaguilera Owned by:
Priority: high Milestone:
Component: AJAX Viewer Version: 2.1.0
Severity: trivial Keywords:
Cc: External ID:

Description

Return to home page task button fails in MGOS2.1. In my case de URL for home task is: ../PROJECTNAME/start.php

The button works again if I change line 136 of mainframe.php

$taskPaneUrl = urlencode($taskPane->GetInitialTaskUrl?());

to

$taskPaneUrl = $taskPane->GetInitialTaskUrl?();

Change History

Changed 4 years ago by jng

The reason urlencode() is there is because if your task pane url has querystring parameters, the url would've been scrambled up as it got passed down to the task pane.

Could you possibly elaborate more on the reason for failure?

Changed 4 years ago by iaguilera

I see that version 2.0.2 of MGOS worked fine and didn't include this urlencode.

The problem I think is that urlencode is encoding the full url, and must encode only the parameters. Because if my taskpane url is "../PROJECTNAME/start.php" urlencode is going to change the slashes '/' to %2F!!! and my url will be "..%2FPROJECTNAME%2Fstart.php" that doesn't seems ok.

Changed 3 years ago by jng

The solution is to write the *decoded* url out to the template, while still passing the encoded version to child frames.

Changed 3 years ago by jng

  • status changed from new to closed
  • resolution set to fixed

Fixed for 2.2 in r5354,

r5330 fixed this in trunk

Note: See TracTickets for help on using tickets.