Opened 15 years ago

Closed 15 years ago

#1114 closed enhancement (fixed)

Maestro Point Style - FontSymbolType Support

Reported by: crispinatime Owned by: ksgeograf
Priority: high Milestone: Maestro-2.0
Component: Maestro Version:
Severity: minor Keywords:
Cc: External ID:

Description

The existing Maestro point-style editing is limited by the GUI to the simple 'Mark' options. MapGuide supports fonts and symbols also for point representation.

The current workaround is hand-crafting XML.

This ticket is for FontSymbolType support.

Attachments (3)

MAESTRO-Ticket1114.zip (10.6 KB ) - added by crispinatime 15 years ago.
Sample Implementation as DIFF Files for Review
MAESTRO-Ticket1114a.zip (10.0 KB ) - added by crispinatime 15 years ago.
Additional elements to allow save and colour management
Maestro 1114 ks.patch (60.2 KB ) - added by ksgeograf 15 years ago.

Download all attachments as: .zip

Change History (12)

by crispinatime, 15 years ago

Attachment: MAESTRO-Ticket1114.zip added

Sample Implementation as DIFF Files for Review

comment:1 by crispinatime, 15 years ago

Version: 2.0.2

by crispinatime, 15 years ago

Attachment: MAESTRO-Ticket1114a.zip added

Additional elements to allow save and colour management

comment:2 by ksgeograf, 15 years ago

Priority: mediumhigh
Status: newassigned
Type: defectenhancement

For some reason the Trac does not send notifications when adding attachments, so I have just discovered the diffs.

I will apply them to Maestro shortly, thanks!

comment:3 by ksgeograf, 15 years ago

Hi Crispin,

the patch looks good and clean, I will try to fix up on the TODO's where applicable.

Before I can commit the changes, you need to sign a Contributor Licens Agreement: http://mapguide.osgeo.org/files/Individual%20Contributor%20Agreement.pdf

comment:4 by ksgeograf, 15 years ago

Crispin, you have hardcoded font names with a remark to move them into the xml file. Would there be a problem with showing fonts avalible on the local machine instead? Obviously, the user can only use server fonts, but until this is resolved wouldn't this be better?

comment:5 by ksgeograf, 15 years ago

I have cleaned it up a bit, and added support for Bold, Italic and Underline.

A full modified patch is attached to this ticket.

I have written you as "Crispin" on the Credits tab, please notify me, if you want something else.

by ksgeograf, 15 years ago

Attachment: Maestro 1114 ks.patch added

comment:6 by crispinatime, 15 years ago

Thanks Kenneth,

The URL for the agreement was not loading, but I found the corporate link OK from here: http://mapguide.osgeo.org/developer.html

Any credit should be to "1Spatial Group Ltd" as it's strictly work time that goes into the edits. I'm getting the agreement signed ... should it be attached here or submitted elsewhere?

comment:7 by ksgeograf, 15 years ago

You must fax the agreement (or snail mail it) to the adresse/fax mentioned in the agreement.

comment:8 by tomfukushima, 15 years ago

We received the signed agreement and 1Spatial has been added to the list: http://wiki.osgeo.org/wiki/Contributor_Agreements_Received

comment:9 by ksgeograf, 15 years ago

Resolution: fixed
Status: assignedclosed

Fixed in r4342

Note: See TracTickets for help on using tickets.