Opened 15 years ago

Closed 15 years ago

Last modified 14 years ago

#1110 closed defect (fixed)

Stability improvements

Reported by: brucedechant Owned by: brucedechant
Priority: medium Milestone: 2.2
Component: General Version: 2.1.0
Severity: minor Keywords:
Cc: External ID:

Description

This trac ticket is for stability improvements.

Change History (16)

comment:1 by brucedechant, 15 years ago

Status: new → assigned

comment:2 by brucedechant, 15 years ago

Summary: Stability improvments → Stability improvements

comment:3 by brucedechant, 15 years ago

  • Added check for 0 length strings
  • Added missing stream close_writer(), close_reader() and close() methods. Note: This sometimes caused a TCP/IP mismatch error even though web and server were the same.
  • Removed unused TLS
  • Adjusted guards around thread data

Fixed in sandbox/adsk/2.1 r4268

comment:4 by brucedechant, 15 years ago

  • Added copy constructor and assignment operator to MgUserInformation class
  • Added copy constructor and assignment operator to MgConnection class
  • Make a copy of the MgUserInformation to be owned by the TLS
  • Make a copy of the MgConnection to be owned by the TLS

Fixed in sandbox/adsk/2.1 r4269

comment:5 by brucedechant, 15 years ago

Resolution: → fixed
Status: assigned → closed

comment:6 by brucedechant, 15 years ago

Small update:

comment:7 by brucedechant, 15 years ago

Update usage of SetCurrentUserInfo() because of the TLS now having a copy of the MgUserInformation.

comment:8 by brucedechant, 14 years ago

Update mutex usage.

comment:9 by brucedechant, 14 years ago

Updated SetCurrentUserInfo to use SAFE_ADDREF/SAFE_RELEASE due to double free memory error on Linux

This is what the error looked like and it would cause the server to crash on Linux: * glibc detected * ./mgserver: double free or corruption (fasttop): 0xa784f928 *

sandbox/adsk/2.1 r4930

comment:10 by brucedechant, 14 years ago

Add guard around GetInformationProperties()

sandbox/adsk/2.1 r4937

comment:11 by brucedechant, 14 years ago

Add guard around GetInformationProperties()

trunk r4950

comment:12 by brucedechant, 14 years ago

Updated SetCurrentUserInfo to use SAFE_ADDREF/SAFE_RELEASE due to double free memory error on Linux

This is what the error looked like and it would cause the server to crash on Linux: * glibc detected * ./mgserver: double free or corruption (fasttop): 0xa784f928 *

trunk r4951

comment:13 by brucedechant, 14 years ago

Set memory checking to report only and not abort on Linux. (ie: Report double frees without aborting)

Note this does not apply to Windows because it does not abort on memory checks.

comment:14 by brucedechant, 14 years ago

Add guard around GetInformationProperties()

sandbox/adsk/2.2gp r4955

comment:15 by brucedechant, 14 years ago

Updated SetCurrentUserInfo to use SAFE_ADDREF/SAFE_RELEASE due to double free memory error on Linux

This is what the error looked like and it would cause the server to crash on Linux: * glibc detected * ./mgserver: double free or corruption (fasttop): 0xa784f928 *

sandbox/adsk/2.2gp r4956

comment:16 by brucedechant, 14 years ago

Change MgConnection so that a copy is not made as it is not needed. This also fixes the session log missing CLIENT and CLIENTIP information.

Note: See TracTickets for help on using tickets.