g.html2man.py fails while processing keyword list

[marisn]

GRASS trunk r61272

VERSION_NUMBER=7.1.svn /home/maris/soft/grass_trunk/dist.x86_64-unknown-linux-gnu/tools/g.html2man.py /home/maris/soft/grass_trunk/dist.x86_64-unknown-linux-gnu/docs/html/keywords.html /home/maris/soft/grass_trunk/dist.x86_64-unknown-linux-gnu/docs/man/man1/keywords.1
/home/maris/soft/grass_trunk/dist.x86_64-unknown-linux-gnu/docs/html/keywords.html:16:0: Error (IndexError('pop from empty list',)): <dt><b><h2>SYNOPSIS</h2></b></dt><dd> <a href="test.raster3d.lib.html">test.raster3d.lib</a></dd>

[wenzeslaus]

This was fixed by r61274 done by Soeren. r61275 compiles now.

However, we may consider if this is in fact bug in GRASS parser or g.html2man.py. Perhaps, parser should not allow no keywords (checked in G_parser() or "--help" function and company) and/or g.html2man.py should provide better error message or work with an empty keywords list. The error message also suggests that output of --html-description is not a valid HTML (if there are no keywords) and if this is the case, this should be fixed in the first place.

[glynn]

Replying to wenzeslaus:

However, we may consider if this is in fact bug in GRASS parser or g.html2man.py.

Or possibly in man/build_keywords.py.

That script appears to be trying to parse HTML using Python's generic string-processing functions, which is unlikely to be robust. Consider using tools/g.html2man/html.py.

[neteler]

Milestone renamed

[neteler]

Ticket retargeted after milestone closed

[neteler]

Ticket retargeted after milestone closed

[martinl]

Issue seems to be solved.