travis failing on 3.5.2 CMAKE clang

[robe]

It seems to be just the CMAKE clang builds on travis failing

​https://travis-ci.com/libgeos/geos/jobs/138223897

with error:

[ 82%] Building CXX object tests/unit/CMakeFiles/geos_unit.dir/algorithm/AngleTest.cpp.o
In file included from /home/travis/build/libgeos/geos/tests/unit/algorithm/AngleTest.cpp:5:
In file included from /home/travis/build/libgeos/geos/tests/unit/tut/tut.hpp:18:
In file included from /home/travis/build/libgeos/geos/tests/unit/tut/tut_exception.hpp:5:
/home/travis/build/libgeos/geos/tests/unit/tut/tut_result.hpp:13:15: error: use of undeclared identifier 'getpid'; did you mean 'getpt'?
        : pid(getpid())
              ^~~~~~
              getpt
/usr/include/stdlib.h:944:12: note: 'getpt' declared here
extern int getpt (void);
           ^
1 error generated.
make[2]: *** [tests/unit/CMakeFiles/geos_unit.dir/algorithm/AngleTest.cpp.o] Error 1
make[1]: *** [tests/unit/CMakeFiles/geos_unit.dir/all] Error 2
make: *** [all] Error 2

{
  "os": "linux",
  "env": "GEOS_BUILD_TOOL=cmake CFLAGS=-m32 CXXFLAGS=-m32",
  "dist": "trusty",
  "sudo": false,
  "group": "stable",
  "addons": {
    "apt": {
      "packages": [
        "gcc-multilib",
        "g++-multilib",
        "cmake",
        "make"
      ]
    }
  },
  "script": "./tools/ci/script.sh",
  "compiler": "clang",
  "language": "cpp"
}

and

{

"os": "linux", "env": "GEOS_BUILD_TOOL=cmake CFLAGS=-m64 CXXFLAGS=-m64", "dist": "trusty", "sudo": false, "group": "stable", "addons": {

"apt": {

"packages": [

"gcc-multilib", "g++-multilib", "cmake", "make"

]

}

}, "script": "./tools/ci/script.sh", "compiler": "clang", "language": "cpp"

}

But these cmake ones work fine:

{
  "os": "linux",
  "env": "GEOS_BUILD_TOOL=cmake CFLAGS=-m32 CXXFLAGS=-m32",
  "dist": "trusty",
  "sudo": false,
  "group": "stable",
  "addons": {
    "apt": {
      "packages": [
        "gcc-multilib",
        "g++-multilib",
        "cmake",
        "make"
      ]
    }
  },
  "script": "./tools/ci/script.sh",
  "compiler": "g++",
  "language": "cpp"
}



{
  "os": "linux",
  "env": "GEOS_BUILD_TOOL=cmake CFLAGS=-m64 CXXFLAGS=-m64",
  "dist": "trusty",
  "sudo": false,
  "group": "stable",
  "addons": {
    "apt": {
      "packages": [
        "gcc-multilib",
        "g++-multilib",
        "cmake",
        "make"
      ]
    }
  },
  "script": "./tools/ci/script.sh",
  "compiler": "g++",
  "language": "cpp"
}

[Paul Ramsey <pramsey@…>]

In e907dee1/git:

Try and fix missing 'getpid' problem
References #907

[Paul Ramsey <pramsey@…>]

In 53df819/git:

Try and put the fix in the right defines
References #907

[pramsey]

​https://travis-ci.com/libgeos/geos/builds/98543219