Opened 6 years ago

Closed 6 years ago

#906 closed defect (duplicate)

Declarations hides class members

Reported by: cvvergara Owned by: cvvergara
Priority: minor Milestone: 3.8.0
Component: Build/Install (cmake) Version: 3.6.2
Severity: Annoyance Keywords:
Cc:

Description

Warnings of this sort are detected on AppVeyor, but not on travis

c:\projects\geos\include\geos\noding\segmentintersectiondetector.h(79): warning C4458: declaration of 'findProper' hides class member (compiling source file C:\projects\geos\src\geom\prep\AbstractPreparedPolygonContains.cpp) [C:\projects\geos\src\geos.vcxproj]

c:\projects\geos\include\geos\noding\segmentintersectiondetector.h(48): note: see declaration of 'geos::noding::SegmentIntersectionDetector::findProper' (compiling source file C:\projects\geos\src\geom\prep\AbstractPreparedPolygonContains.cpp)

c:\projects\geos\include\geos\noding\segmentintersectiondetector.h(84): warning C4458: declaration of 'findAllTypes' hides class member (compiling source file C:\projects\geos\src\geom\prep\AbstractPreparedPolygonContains.cpp) [C:\projects\geos\src\geos.vcxproj]

c:\projects\geos\include\geos\noding\segmentintersectiondetector.h(49): note: see declaration of 'geos::noding::SegmentIntersectionDetector::findAllTypes' (compiling source file C:\projects\geos\src\geom\prep\AbstractPreparedPolygonContains.cpp)

Tasks

  • add -Wshadow
  • fix the declarations

Change History (1)

comment:1 by cvvergara, 6 years ago

Resolution: → duplicate
Status: assigned → closed

Just noticed, that its a duplicate of #857 Closing

Note: See TracTickets for help on using tickets.