Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#905 closed defect (fixed)

warning C4251 (appVeyor)

Reported by: cvvergara Owned by: robe
Priority: minor Milestone: 3.8.0
Component: Buildbots Version: 3.6.2
Severity: Annoyance Keywords:
Cc:

Description

Annoying warning from a "stupid compiler"

c:\projects\geos\include\geos\precision\minimumclearance.h(32): warning C4251: 'geos::precision::MinimumClearance::minClearancePts': class 'std::unique_ptr<geos::geom::CoordinateSequence,std::default_delete<_Ty>>' needs to have dll-interface to be used by clients of class 'geos::precision::MinimumClearance' [C:\projects\geos\src\geos.vcxproj]

c:\projects\geos\include\geos\triangulate\quadedge\quadedgesubdivision.h(96): warning C4251: 'geos::triangulate::quadedge::QuadEdgeSubdivision::quadEdges': class 'std::vector<geos::triangulate::quadedge::QuadEdge *,std::allocator<_Ty>>' needs to have dll-interface to be used by clients of class 'geos::triangulate::quadedge::QuadEdgeSubdivision' [C:\projects\geos\src\geos.vcxproj]

Basically it shows on identifiers for stl stuff like vector, unique_ptr etc

Change History (2)

comment:1 by cvvergara <vicky@…>, 6 years ago

Resolution: fixed
Status: newclosed

In 71e8b93/git:

Ignoring warning 4251 on MSVS Closes #905

This is a combination of 2 commits.

comment:2 by Gitea <gitea@…>, 6 years ago

In 5ecabd64/git:

Merge branch 'fix-issue905' of cvvergara/geos into master

Note: See TracTickets for help on using tickets.